Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade labstack echo #1688

Closed
wants to merge 2 commits into from
Closed

Conversation

2dvorak
Copy link
Collaborator

@2dvorak 2dvorak commented Nov 11, 2022

Proposed changes

  • The go module labstack/echo/v4 before v4.9.0 has vulnerability, see its issue.
  • The klaytn uses DataDog/dd-trace-go which imports a vulnerable version of labstack/echo/v4. However, it has not updated labstack/echo/v4 to a patched version because its maintainers want to use lowest version possible(despite the vulnerability). See its issue.
  • We can manually replace the vulnerable version of labstack/echo/v4 by adding the replace directive in go.mod. Then running go mod tidy will replace vulnerable version (i.e., v4.2.0) of labstack/echo/v4 in go.sum.

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

  • This issue was submitted via dependabot.

Further comments

None

The module DataDog/dd-trace-go imports labstack/echo v4.2.0,
which has vulnerability. Thus force go.mod to use patched version
v4.9.0 instead, by adding `replace` directive.
Reference: DataDog/dd-trace-go#1458
@2dvorak
Copy link
Collaborator Author

2dvorak commented Nov 14, 2022

Seems Klaytn code is not affected, closing this PR for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant