Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update danger-rubocop #56

Merged
merged 1 commit into from Apr 18, 2022
Merged

Update danger-rubocop #56

merged 1 commit into from Apr 18, 2022

Conversation

Quiwin
Copy link
Contributor

@Quiwin Quiwin commented Apr 14, 2022

Bump rubocop and rubocop-danger for ruby 3 support.
See rubocop/rubocop#10424 and ashfurrow/danger-rubocop#56

@Quiwin Quiwin marked this pull request as ready for review April 14, 2022 09:42
hugobarthelemy
hugobarthelemy approved these changes Apr 14, 2022
View reviewed changes
Copy link
Member

@hugobarthelemy hugobarthelemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Quiwin Quiwin merged commit 48d1425 into master Apr 18, 2022
@Quiwin Quiwin deleted the feature/update-danger-rubocop branch April 18, 2022 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugobarthelemy hugobarthelemy hugobarthelemy approved these changes

Assignees

@Quiwin Quiwin

@teckwan teckwan

@JoakimKlaxit JoakimKlaxit

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Quiwin @hugobarthelemy @teckwan @JoakimKlaxit @AntoineGirard