deflate: Separate code and lengths #619
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Experiment by adding golang/go#46007 from @teivah Before/after: ``` file out level insize outsize millis mb/s github-ranks-backup.bin gzkp 1 1862623243 458201422 6979 254.51 github-ranks-backup.bin gzkp 1 1862623243 458201422 7273 244.22 enwik9 gzkp 1 1000000000 382781160 5805 164.26 enwik9 gzkp 1 1000000000 382781160 5976 159.57 github-ranks-backup.bin gzkp -2 1862623243 1298789681 5592 317.65 github-ranks-backup.bin gzkp -2 1862623243 1298789681 5420 327.70 ``` Slower for general compression, but faster for huffman only compression.
klauspost
added a commit
that referenced
this pull request
Jun 8, 2022
~5% Faster for huffman-only, same for rest. ``` github-ranks-backup.bin gzkp -2 1862623243 1298789681 5547 320.22 github-ranks-backup.bin gzkp -2 1862623243 1298789681 5305 334.83 ``` Replaces #619 - more speedup, and no regression.
|
See #622 for better alternative. |
klauspost
added a commit
that referenced
this pull request
Jun 9, 2022
~5% Faster for huffman-only, same for rest. ``` github-ranks-backup.bin gzkp -2 1862623243 1298789681 5547 320.22 github-ranks-backup.bin gzkp -2 1862623243 1298789681 5305 334.83 ``` Replaces #619 - more speedup, and no regression.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Experiment by adding golang/go#46007 from @teivah
Before/after:
Slower for general compression, but faster for huffman only compression.