zstd: Store previous offsets in registers #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not super visible in microbenches (presumably because of cache), but very visible in streaming decodes. Before/after: ``` BenchmarkDecoderSilesia-32 4 281168525 ns/op 753.81 MB/s 50218 B/op 44 allocs/op BenchmarkDecoderSilesia-32 6 190584583 ns/op 1112.09 MB/s 49446 B/op 45 allocs/op BenchmarkDecoderEnwik9-32 1 1439964200 ns/op 694.46 MB/s 71952 B/op 51 allocs/op BenchmarkDecoderEnwik9-32 1 1184307200 ns/op 844.38 MB/s 72144 B/op 53 allocs/op ```
|
@WojciechMula Do you have objections to this? I can hold this off if it interferes with #545 |
Great! Please merge, there are no problems with rebasing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not super visible in microbenches (presumably because of cache), but very visible in streaming decodes.
Before/after: