Format code #173
Open
Format code #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, configure isort to use compatible formatting.
This also addresses a formatting discrepancy in `idna-data` so that it aligns with the isort formatting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces black and isort as pre-commit hooks.
For now, the project's generated files are excluded from black's reformatting instead of making the generated output match.
Please let me know if additional changes are needed.
Note
If this merges, I strongly recommend enabling pre-commit.ci for this project so that incoming PRs are automatically subjected to linting and reformatting.
In addition, enabling pre-commit.ci will cause the service to submit PRs on a quarterly basis (if needed) to update the hook versions in
.pre-commit-config.yaml.Closes #157