Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setup cfg #148

Merged
merged 2 commits into from
Nov 23, 2023
Merged

Add setup cfg #148

merged 2 commits into from
Nov 23, 2023

Conversation

kjd
Copy link
Owner

@kjd kjd commented Aug 26, 2023

No description provided.

@sethmlarson
Copy link
Collaborator

I'm not sure I understand this, we already have a pyproject.toml and are using flit_core as a build system. We shouldn't need a setup.cfg if we're not using setuptools.

@Odilhao
Copy link

Odilhao commented Aug 28, 2023

I'm not sure I understand this, we already have a pyproject.toml and are using flit_core as a build system. We shouldn't need a setup.cfg if we're not using setuptools.

This affects specially OS packaging, Centos8 Stream for example don't have a native support for PEP-517, the same probably applies for Debian/Ubuntu LTS, #129 reports that.

@sethmlarson
Copy link
Collaborator

sethmlarson commented Aug 28, 2023

I've replied in #129: #129 (comment)

Copy link

@jayvdb jayvdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for maintaining backwards compatibility.

@kjd kjd merged commit fc91a61 into master Nov 23, 2023
30 checks passed
@kjd kjd deleted the add-setup-cfg branch November 23, 2023 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants