Skip to content

Commit

Permalink
Flake8 does not support inline comments for any of the keys. (#2708)
Browse files Browse the repository at this point in the history
* Flake8 does not support inline comments for any of the keys.

* Fix flake8 E741 ambiguous variable name
  • Loading branch information
misl6 committed Nov 29, 2022
1 parent e14bdfc commit 8f8cf6a
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 9 deletions.
2 changes: 1 addition & 1 deletion pythonforandroid/recipe.py
Original file line number Diff line number Diff line change
Expand Up @@ -631,7 +631,7 @@ def install_libs(self, arch, *libs):
shprint(sh.cp, *args)

def has_libs(self, arch, *libs):
return all(map(lambda l: self.ctx.has_lib(arch.arch, l), libs))
return all(map(lambda lib: self.ctx.has_lib(arch.arch, lib), libs))

def get_libraries(self, arch_name, in_context=False):
"""Return the full path of the library depending on the architecture.
Expand Down
24 changes: 16 additions & 8 deletions tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,19 @@ commands = flake8 pythonforandroid/ tests/ ci/ setup.py

[flake8]
ignore =
E123, # Closing bracket does not match indentation of opening bracket's line
E124, # Closing bracket does not match visual indentation
E126, # Continuation line over-indented for hanging indent
E226, # Missing whitespace around arithmetic operator
E402, # Module level import not at top of file
E501, # Line too long (82 > 79 characters)
W503, # Line break occurred before a binary operator
W504 # Line break occurred after a binary operator
# Closing bracket does not match indentation of opening bracket's line
E123,
# Closing bracket does not match visual indentation
E124,
# Continuation line over-indented for hanging indent
E126,
# Missing whitespace around arithmetic operator
E226,
# Module level import not at top of file
E402,
# Line too long (82 > 79 characters)
E501,
# Line break occurred before a binary operator
W503,
# Line break occurred after a binary operator
W504

0 comments on commit 8f8cf6a

Please sign in to comment.