Track which symbol was used to mark task item as checked #252
Conversation
There was a problem hiding this comment.
This is looking excellent — thank you! I have a few comments on cleaning this up for merge which I think should be no trouble at all.
The only blocking issue is the now-failing spec tests. The GFM spec for task list items only recognises task list items where the marker contains whitespace, x or X in the square brackets. We're now recognising tasklists with anything inside those square brackets.
Because we're not only saving additional information about the input, but also changing the interpretation of it, we'll need to use the relaxed regex only when an flag/option is specified.
|
Great! As soon as we have the new option, we're good to go. Did you want to do that, or would you prefer I did? |
|
I totally forgot about the flag 😅 Should this be a free-standing option or somehow tied to the TaskList extension? |
|
Awesome, thank you so much! Free-standing is totally fine for the option. I've added two commits — one (a5efb05) to demonstrate an issue, and one (59e2ef5) with a suggested fix. The problem is that the regex is only initialised once for the lifetime of the program, so the first time a tasklist is processed, the setting of the option at that time is then used for all subsequent invocations. If you're happy enough with my fix, let me know, but I didn't want to dictate the answer seeing as it's your feature! Feel free to amend it or drop the commit and do it a different way if you want. :) |
|
Yeah this looks brilliant 👍 |
|
Awesome. Thank you so much! |
No description provided.