Make comrak --help readable on my terminal
#242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When I run `comrak --help` on my terminal, I see unwrapped and very hard-to-read output. With the `wrap_help` Cargo option for Clap, we can make it produce much more readable output. The output will even adapt to the terminal width (similar to man(1)) and thus look good in many situations.
|
When playing with this, I noticed that the text finally wrapped correct with a terminal which is 120 columns wide. I'm basically suggesting not to hard-code this and instead use a millisecond or two at runtime to adapt the text to match :-) |
|
This is a wonderful contribution — thanks so much, really appreciate it! |
|
Hi @kivikakk, thanks, I'm very happy to help where I can! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I run
comrak --helpon my terminal, I see unwrapped and very hard-to-read output.This is what I see:
The output is similar with a 100 columns terminal:
With the
wrap_helpCargo option for Clap, we can make it produce much more readable output. The output will even adapt to the terminal width (similar to man(1)) and thus look good in many situations: