c-api: fix CI build #240
Merged
c-api: fix CI build #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Could I do anything to help here? I've finally got multiplatform gem compilation working (gjtorikian/commonmarker#189), but the Windows gem doesn't seem to be building. I wonder if it's related to this change? |
|
I'm sure it's related, yeah. Any help you could offer would be appreciated — life's gotten tricky so I might not have time for a couple weeks at least. |
|
I'm just going to merge this for now to get comrak's own CI going again so I can assess other PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Broken by 12c32fa.
Of course, it does break commonmarker. Currently got Linux/mac builds OK, but working through Windows whatever: https://github.com/gjtorikian/commonmarker/actions/runs/2857777814