Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(type assert): add more check for type assert #246

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(type assert): add more check for type assert #246

wants to merge 1 commit into from

Conversation

meteorgan
Copy link
Contributor

fix #224

@meteorgan meteorgan marked this pull request as ready for review April 17, 2024 13:44
dtcaciuc
dtcaciuc requested changes May 14, 2024
View reviewed changes
errcheck/errcheck.go
}

case *ast.TypeAssertExpr:
v.checkAssertExpr(stmt)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You made this method return a boolean but you're not using the return value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtcaciuc dtcaciuc dtcaciuc requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Report unchecked type-assertion when returning value and when passing it to other func
2 participants
@meteorgan @dtcaciuc