Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move errcheck package out of internal #185

Merged
merged 25 commits into from Dec 10, 2020
Merged

Move errcheck package out of internal #185

merged 25 commits into from Dec 10, 2020

Commits on Aug 2, 2020

  1. Move errcheck package out of internal 

    Signed-off-by: Eric Chlebek <eric@sensu.io>
    @echlebek
    echlebek committed Aug 2, 2020
    Copy the full SHA
    ea6ea2f View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2020

  1. Merge branch 'master' into publish-api 

    Signed-off-by: Eric Chlebek <eric@sensu.io>
    @echlebek
    echlebek committed Aug 4, 2020
    Copy the full SHA
    ee8ff30 View commit details
    Browse the repository at this point in the history

  2. Fix up the docs a bit 

    Signed-off-by: Eric Chlebek <eric@sensu.io>
    @echlebek
    echlebek committed Aug 4, 2020
    Copy the full SHA
    b03026b View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2020

  1. CheckPackage function

    Sergey Vilgelm committed Aug 19, 2020
    Copy the full SHA
    5665fc9 View commit details
    Browse the repository at this point in the history

  2. Start factoring out exclusion flags into separate struct.

    @dtcaciuc
    dtcaciuc committed Aug 19, 2020
    Copy the full SHA
    b4ad18c View commit details
    Browse the repository at this point in the history

  3. Move Checker.exclude to Checker.Exclusions.Symbols

    @dtcaciuc
    dtcaciuc committed Aug 19, 2020
    Copy the full SHA
    f1024b1 View commit details
    Browse the repository at this point in the history

  4. Move Checker.Blank and Checker.Asserts to Exclusions

    @dtcaciuc
    dtcaciuc committed Aug 19, 2020
    Copy the full SHA
    b694f8e View commit details
    Browse the repository at this point in the history

  5. Move Checker.Ignore to Exclusions.Packages, remove NewChecker

    @dtcaciuc
    dtcaciuc committed Aug 19, 2020
    Copy the full SHA
    5c4c914 View commit details
    Browse the repository at this point in the history

  6. Clarify -ignore deprecation message

    @dtcaciuc
    dtcaciuc committed Aug 19, 2020
    Copy the full SHA
    f394fab View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2020

  1. Merge pull request #188 from SVilgelm/publish-api 

    CheckPackage function
    @echlebek
    echlebek committed Aug 31, 2020
    Copy the full SHA
    7c04f7d View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/publish-api' into exclusions 

    I've taken the liberty of modifying the incoming changes somewhat.
The UpdateNonVendoredIgnore function has been renamed, unexported,
and made to return data instead of setting it.
    @echlebek
    echlebek committed Aug 31, 2020
    Copy the full SHA
    3c3d64d View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2020

  1. Simplify vendored package resolution. 

    Independent of whether go mod is used or not, simply
strip off vendor directory prefix from both imports
and excludes if it was found.
    @dtcaciuc
    dtcaciuc committed Oct 10, 2020
    Copy the full SHA
    181d1bd View commit details
    Browse the repository at this point in the history

  2. Merge pull request #1 from dtcaciuc/rm-mod-check 

    Simplify vendored package resolution.
    @dtcaciuc
    dtcaciuc committed Oct 10, 2020
    Copy the full SHA
    672a183 View commit details
    Browse the repository at this point in the history

  3. Restore legacy ignore functionality; fix docstrings

    @dtcaciuc
    dtcaciuc committed Oct 10, 2020
    Copy the full SHA
    bd31643 View commit details
    Browse the repository at this point in the history

  4. Clean up comments; add future improvement TODO

    @dtcaciuc
    dtcaciuc committed Oct 10, 2020
    Copy the full SHA
    bf59cbd View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2020

  1. Merge pull request #189 from dtcaciuc/exclusions 

    Factor out exclusion flags into a separate struct
    @echlebek
    echlebek committed Oct 23, 2020
    Copy the full SHA
    720fbcb View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2020

  1. Remove CheckPaths 

    This commit removes the CheckPaths method of Checker. It also
adds a method called LoadPackages, and exports more of the logic
that errcheck uses to do aggregation.

The UncheckedErrors type has been renamed to Result, and the
CheckPackage function now returns a *Result instead of
[]UncheckedErrors.

Signed-off-by: Eric Chlebek <eric@sensu.io>
    @echlebek
    echlebek committed Oct 25, 2020
    Copy the full SHA
    677f1d6 View commit details
    Browse the repository at this point in the history

  2. Refactor main.checkPaths a bit 

    Signed-off-by: Eric Chlebek <eric@sensu.io>
    @echlebek
    echlebek committed Oct 25, 2020
    Copy the full SHA
    8d25d8e View commit details
    Browse the repository at this point in the history

  3. Remove mutex, Errors->UncheckedErrors 

    Signed-off-by: Eric Chlebek <eric@sensu.io>
    @echlebek
    echlebek committed Oct 25, 2020
    Copy the full SHA
    beb76a6 View commit details
    Browse the repository at this point in the history

  4. Implement locking in main 

    Signed-off-by: Eric Chlebek <eric@sensu.io>
    @echlebek
    echlebek committed Oct 25, 2020
    Copy the full SHA
    53abe15 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2020

  1. Remove sort.Interface from Result 

    As suggested by dtcaciuc

Signed-off-by: Eric Chlebek <eric@sensu.io>
    @echlebek
    echlebek committed Nov 10, 2020
    Copy the full SHA
    cfa64d0 View commit details
    Browse the repository at this point in the history

  2. Don't mutate Result on Unique() 

    Signed-off-by: Eric Chlebek <eric@sensu.io>
    @echlebek
    echlebek committed Nov 10, 2020
    Copy the full SHA
    c4c6bdd View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2020

  1. Merge pull request #193 from kisielk/no-check-path 

    Remove CheckPaths
    @kisielk
    kisielk committed Nov 13, 2020
    Copy the full SHA
    c1c14fd View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2020

  1. Clarify Result docs 

    Signed-off-by: Eric Chlebek <eric@sensu.io>
    @echlebek
    echlebek committed Dec 10, 2020
    Copy the full SHA
    6afc191 View commit details
    Browse the repository at this point in the history

  2. Make API less pointery. Get rid of error interface. 

    Signed-off-by: Eric Chlebek <eric@sensu.io>
    @echlebek
    echlebek committed Dec 10, 2020
    Copy the full SHA
    97c82e3 View commit details
    Browse the repository at this point in the history