Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sarpik/create-react-app-docs-update #5

Merged
merged 5 commits into from
Feb 2, 2020
Merged

sarpik/create-react-app-docs-update #5

merged 5 commits into from
Feb 2, 2020

Conversation

kiprasmel
Copy link
Owner

@kiprasmel kiprasmel commented Feb 2, 2020 •
edited

@kiprasmel
You do *not* need to eject 🥳
a821eda 
Signed-off-by: Kipras Melnikovas <kipras@kipras.org>
@kiprasmel
Nest react's package.json instructions
55539a2 
Signed-off-by: Kipras Melnikovas <kipras@kipras.org>
@kiprasmel
Add react's package.json instruction to manually upgrade eslint to v6
2a9f9aa 
See #3 (#3)

Signed-off-by: Kipras Melnikovas <kipras@kipras.org>
@kiprasmel
Add react's package.json instruction to append --ext js,jsx,ts,tsx …
119d184 
…option to eslint

See #4 (#4)

Also updated this project's package.json - the change is not needed for
eslint v5, but it's compatible with both v5 & v6, so it won't hurt.

Signed-off-by: Kipras Melnikovas <kipras@kipras.org>
@kiprasmel
Add a sample package.json for react's (CRA) example @ README
7db59f2 
Signed-off-by: Kipras Melnikovas <kipras@kipras.org>
@kiprasmel kiprasmel self-assigned this Feb 2, 2020
@kiprasmel kiprasmel marked this pull request as ready for review February 2, 2020 21:26
@kiprasmel kiprasmel merged commit 3f5c90e into master Feb 2, 2020
@kiprasmel kiprasmel deleted the sarpik/create-react-app-docs-update branch February 2, 2020 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kiprasmel kiprasmel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@kiprasmel