This repository has been archived by the owner on Jun 29, 2022. It is now read-only.
CopyWalker: truncate file when writing #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iaguis
reviewed
Feb 27, 2020
invidian
force-pushed
the
invidian/fix-copying-walker
branch
from
6ba04b5
to
a743677
Compare
iaguis
previously approved these changes
Feb 27, 2020
pkg/util/walkers/copying.go
Outdated
| defer f.Close() | ||
|
|
||
| if _, err := io.Copy(f, r); err != nil { | ||
| return fmt.Errorf("failed writing to file %s: %v", p, err) |
There was a problem hiding this comment.
Suggested change
| return fmt.Errorf("failed writing to file %s: %v", p, err) | |
| return fmt.Errorf("failed writing to file %s: %w", p, err) |
|
I'll modify the PR to use |
So at least some changes to this function can be easily tested. Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>
iaguis
force-pushed
the
invidian/fix-copying-walker
branch
4 times, most recently
from
b8231dd
to
4aab93c
Compare
To avoid leaving old content untouched when updating files, which may happen if new content is smaller than the old one. Closes #40 Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>
iaguis
force-pushed
the
invidian/fix-copying-walker
branch
from
4aab93c
to
4d934df
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid leaving old content untouched when updating files, which may
happen if new content is smaller than the old one.
Closes #40
Signed-off-by: Mateusz Gozdek mateusz@kinvolk.io