Issue 120 Fix bug cannot create Tag Definitions #386
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue raised here: rack/rack#2128
I found that the issue comes from the rack gem, the parse_nested_query function.
The Gemfile from killbill-admin-ui:
gem 'rails', '~> 7.0.1'
->rails 7.0.8
-> will install rack 2.2.8The Gemfile from killbill-admin-ui-standalone:
gem 'rails', '~> 7.0.0'
->rails 7.1.2
-> will install rack 3.0.8You can compare the parse_nested_queryhere:
Here is our raw source data for POST:
And the result when using Rack::Utils.parse_nested_query:
Rack 3.0 no longer supports parsing nested params like a[b[c]], the correct nested params should be a[b][c].