Refactor and trap localStorage and JSON parsing errors #48
+310
−60
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main reason for this PR is to trap exceptions being thrown by
localStorage
(of which there are many weird cases across different platforms and browsers), andJSON.parse()
.Exceptions are logged to the console as warnings, by default, re-using
disableWarnings
to silence them. This means thatdisableWarnings
is now needed as an option forsave()
andclear()
as well.Also includes some trivial refactoring in digestible small commits that steer toward the final commit.