Skip to content

Commit

Permalink
fix(firefox): fix executablePath() on OSX (puppeteer#4105)
Browse files Browse the repository at this point in the history
OSX might have case-sensitive partitions, so make sure we're precise.

Fix puppeteer#4102
  • Loading branch information
aslushnikov authored and kiku-jw committed Apr 6, 2019
1 parent 659a882 commit 138d52c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion experimental/puppeteer-firefox/lib/BrowserFetcher.js
Expand Up @@ -206,7 +206,7 @@ class BrowserFetcher {
throw new Error('Unsupported platform: ' + this._platform);
} else if (this._product === 'firefox') {
if (this._platform === 'mac')
executablePath = path.join(folderPath, 'firefox', 'Nightly.app', 'Contents', 'MacOS', 'Firefox');
executablePath = path.join(folderPath, 'firefox', 'Nightly.app', 'Contents', 'MacOS', 'firefox');
else if (this._platform === 'linux')
executablePath = path.join(folderPath, 'firefox', 'firefox');
else if (this._platform === 'win32' || this._platform === 'win64')
Expand Down

0 comments on commit 138d52c

Please sign in to comment.