chore: Optimize array split (koajs#1295)

kiku-jw · Feb 26, 2019 · 2389460 · 2389460
1 parent 6a38882
commit 2389460
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/lib/request.js b/lib/request.js
@@ -257,7 +257,7 @@ module.exports = {
       if (!host) host = this.get('Host');
     }
     if (!host) return '';
-    return host.split(/\s*,\s*/)[0];
+    return host.split(/\s*,\s*/, 1)[0];
   },
 
   /**
@@ -273,7 +273,7 @@ module.exports = {
     const host = this.host;
     if (!host) return '';
     if ('[' == host[0]) return this.URL.hostname || ''; // IPv6
-    return host.split(':')[0];
+    return host.split(':', 1)[0];
   },
 
   /**
@@ -404,7 +404,7 @@ module.exports = {
     if (this.socket.encrypted) return 'https';
     if (!this.app.proxy) return 'http';
     const proto = this.get('X-Forwarded-Proto');
-    return proto ? proto.split(/\s*,\s*/)[0] : 'http';
+    return proto ? proto.split(/\s*,\s*/, 1)[0] : 'http';
   },
 
   /**

diff --git a/lib/response.js b/lib/response.js
@@ -381,7 +381,7 @@ module.exports = {
   get type() {
     const type = this.get('Content-Type');
     if (!type) return '';
-    return type.split(';')[0];
+    return type.split(';', 1)[0];
   },
 
   /**