Run lint in compile phase to fail Maven build on Jenkins #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins uses `-Dmaven.test.failure.ignore` to run the complete build even if some tests are failing. Frontend plugin honors this property in such a way that any goal ran in the test phase doesn't fail the build (even if it returns non-zero code) but we want typecheck and lint to fail the build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jenkins uses
-Dmaven.test.failure.ignoreto run the complete buildeven if some tests are failing. Frontend plugin honors this property
in such a way that any goal ran in the test phase doesn't fail
the build (even if it returns non-zero code) but we want typecheck
and lint to fail the build.
Frontend plugin issue with related information: eirslett/frontend-maven-plugin#534.