Performance / custom dashboards: new configs #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmazzitelli
requested changes
Feb 3, 2021
deploy/kiali/kiali_cr.yaml
Outdated
| # discovery_enabled: auto | ||
| # discovery_auto_threshold: 10 |
There was a problem hiding this comment.
All peer settings in the operator config files are sorted alphabetically. Sort these alphabetically:
Suggested change
| # discovery_enabled: auto | |
| # discovery_auto_threshold: 10 | |
| # discovery_auto_threshold: 10 | |
| # discovery_enabled: auto |
| discovery_enabled: "auto" | ||
| discovery_auto_threshold: 10 |
There was a problem hiding this comment.
All peer settings in the operator config files are sorted alphabetically. Sort these alphabetically:
Suggested change
| discovery_enabled: "auto" | |
| discovery_auto_threshold: 10 | |
| discovery_auto_threshold: 10 | |
| discovery_enabled: "auto" |
deploy/kiali/kiali_cr.yaml
Outdated
Comment on lines
411
to
420
| # discovery_enabled: Enable, disable or set 'auto' mode to the dashboards discovery process. If set to true, Kiali | ||
| # will always try to discover dashboards based on metrics. Note that it can generate performance penalties while | ||
| # discovering dashboards for workloads having many pods (thus many metrics), especially with versions of Prometheus < 2.24. | ||
| # When set to 'auto', Kiali will skip dashboards discovery for workloads with more than a configured threshold of pods | ||
| # (see 'discovery_auto_threshold'). When discovery is disabled or auto/skipped, it is still possible to tie workloads | ||
| # with dashboards through annotations on pods (refer to the doc https://kiali.io/documentation/latest/runtimes-monitoring/#pods-annotations) | ||
| # Allowed values: true, false, auto. Default: auto. | ||
| # discovery_auto_threshold: Threshold of pods, for a given Application or Workload, above which dashboards discovery will be skipped | ||
| # when in 'auto' mode. Default: 10. | ||
| # enabled: Enable or disable custom dashboards, including the dashboards discovery process. Default: true. |
There was a problem hiding this comment.
All peer settings in the operator config files are sorted alphabetically. Sort these alphabetically. Also, tweaked some of this for more clarity, and no need to mention the "Default" in the text of the description - all the commented values in this example CR file are the documented default values.
Suggested change
| # discovery_enabled: Enable, disable or set 'auto' mode to the dashboards discovery process. If set to true, Kiali | |
| # will always try to discover dashboards based on metrics. Note that it can generate performance penalties while | |
| # discovering dashboards for workloads having many pods (thus many metrics), especially with versions of Prometheus < 2.24. | |
| # When set to 'auto', Kiali will skip dashboards discovery for workloads with more than a configured threshold of pods | |
| # (see 'discovery_auto_threshold'). When discovery is disabled or auto/skipped, it is still possible to tie workloads | |
| # with dashboards through annotations on pods (refer to the doc https://kiali.io/documentation/latest/runtimes-monitoring/#pods-annotations) | |
| # Allowed values: true, false, auto. Default: auto. | |
| # discovery_auto_threshold: Threshold of pods, for a given Application or Workload, above which dashboards discovery will be skipped | |
| # when in 'auto' mode. Default: 10. | |
| # enabled: Enable or disable custom dashboards, including the dashboards discovery process. Default: true. | |
| # discovery_auto_threshold: Threshold of the number of pods, for a given Application or Workload, above which dashboards discovery will be skipped. | |
| # This setting only takes effect when discovery_enabled is set to 'auto' mode. | |
| # discovery_enabled: Enable, disable or set 'auto' mode to the dashboards discovery process. If set to true, Kiali | |
| # will always try to discover dashboards based on metrics. Note that it can generate performance penalties while | |
| # discovering dashboards for workloads having many pods (thus many metrics), especially with versions of Prometheus < 2.24. | |
| # When set to 'auto', Kiali will skip dashboards discovery for workloads with more than a configured threshold of pods | |
| # (see 'discovery_auto_threshold'). When discovery is disabled or auto/skipped, it is still possible to tie workloads | |
| # with dashboards through annotations on pods (refer to the doc https://kiali.io/documentation/latest/runtimes-monitoring/#pods-annotations) | |
| # Allowed values: true, false, auto. | |
| # enabled: Enable or disable custom dashboards, including the dashboards discovery process. |
- discovery_enabled (true/false/auto) to switch discovery mode - discovery_auto_threshold: pods threshold above which discovery is skipped in auto mode Part of kiali/kiali#3660
jotak
force-pushed
the
discovery-switches
branch
from
94b839d
to
aa318e3
Compare
|
Ah, damn alphabetical sort! I've been very careful about that when adding |
hhovsepy
previously approved these changes
Feb 3, 2021
jmazzitelli
requested changes
Feb 3, 2021
|
Ok I didn't notice you changed the text. I also changed it on my side. Need to merge both now |
|
@jmazzitelli ok, pushed again, I hope I didn't miss any of your changes |
jmazzitelli
approved these changes
Feb 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
skipped in auto mode
Part of kiali/kiali#3660
Kiali core PR: kiali/kiali#3668