Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make JUnit test work on windows #383

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

marioja
Copy link

@marioja marioja commented Oct 31, 2023

This checklist will help us to incorporate your contribution quickly and easily:

  • Make sure you have read the contributing guide.
  • Make sure there is a issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Name your branch which contains the pull request accordingly with the issue.
    Best is to follow: issue-Number where Number has be replaced with the issue
    number of the appropriate issue you are offering a pull request for.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like Fixed #Nr - Fixed IT execution.,
    where you replace Nr with the appropriate issue number. It is required
    to use the issue title in the commit message title and in the first line of the
    commit message. They should very similar like the following: Fixed #64 - Automatic site publishing
    You can of course take a look into the existing commit history.
  • Make an appropriate entry into the release notes. Follow the examples
    of the existing release notes.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask via a comment on the appropriate isseu.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@khmarbaise
Copy link
Owner

khmarbaise commented Nov 5, 2023

It's great to see a PR but unfortunately I don't see an related issue for this. Can please create an appropriate issue and describe exactly what the problem is?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants