Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily exclude pydantic 1.8 #62

Merged
merged 2 commits into from Feb 27, 2021
Merged

Temporarily exclude pydantic 1.8 #62

merged 2 commits into from Feb 27, 2021

Conversation

khaeru
Copy link
Owner

@khaeru khaeru commented Feb 27, 2021

Tests began to fail today (https://github.com/khaeru/sdmx/runs/1992616989?check_suite_focus=true) because pydantic 1.8 was released and picked up.

This version includes improvements that will allow to eliminate some or all of the workarounds in sdmx.util; however, it also introduces pydantic/pydantic#2422, for which a workaround is not obvious. This PR temporarily sets a requirement for pydantic < 1.8, until that bug is addressed. A subsequent PR will remove & also adapt to the new version.

This will require a quick patch release, v2.2.1, so that other code installing sdmx1 gets a compatible version of pydantic.

@khaeru khaeru added the bug label Feb 27, 2021
@khaeru khaeru self-assigned this Feb 27, 2021
@codecov
Copy link

codecov bot commented Feb 27, 2021

Codecov Report

Merging #62 (3843655) into master (912dcdc) will decrease coverage by 2.23%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #62      +/-   ##
==========================================
- Coverage   96.94%   94.71%   -2.24%     
==========================================
  Files          53       53              
  Lines        4393     4393              
==========================================
- Hits         4259     4161      -98     
- Misses        134      232      +98     
Impacted Files Coverage Δ
sdmx/source/wb_wdi.py 28.57% <0.00%> (-71.43%) ⬇️
sdmx/source/ilo.py 50.00% <0.00%> (-50.00%) ⬇️
sdmx/source/lsd.py 50.00% <0.00%> (-50.00%) ⬇️
sdmx/source/insee.py 57.14% <0.00%> (-42.86%) ⬇️
sdmx/source/istat.py 57.14% <0.00%> (-42.86%) ⬇️
sdmx/source/estat.py 47.50% <0.00%> (-42.50%) ⬇️
sdmx/source/sgr.py 50.00% <0.00%> (-40.00%) ⬇️
sdmx/source/wb.py 66.66% <0.00%> (-33.34%) ⬇️
sdmx/tests/test_sources.py 71.31% <0.00%> (-28.69%) ⬇️
sdmx/client.py 91.47% <0.00%> (-3.41%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 912dcdc...3843655. Read the comment docs.

@khaeru khaeru merged commit ef407f1 into master Feb 27, 2021
@khaeru khaeru deleted the exclude-pydantic-1.8 branch February 27, 2021 13:20
@khaeru khaeru mentioned this pull request Feb 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant