-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
- Initially suport es6 native modules #101
Conversation
Travis CI tests failed on Node 4. It looks like that tests failed for reasons that I didn't really touch |
Cause it's not too obvious from PR desription I'd rather explain one more time:
|
We will look into this in the week, no worries we will try to make a patch as fast as possible |
Awesome, thanks a bunch @vpotseluyko for the PR and test project, digging in right now |
mark, wait for fix |
Any idea for a release date on this? |
+1 |
1 similar comment
+1 |
From node v8.8.1 we received unstable es6 modules support with flag
--experimental-modules
.(more about it here: https://nodejs.org/api/esm.html)
Es6 modules has broken code which depends on commonJS module system. This pull request allows initially with some hacks support es6 modules.
Note: this provides full backward compatibility with CommonJS project.
Note: I'd hope this will be included in next pmx release - while es6 modules are still experimental feature they are worse supporting right now.
I was not really sure where and how shall I pull request it. Hope dev branch was the right choice.
I created simple project for demonstrating es6 modules usage: https://github.com/vpotseluyko/test-es6-pm2