Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade axios to ^0.21 #71

Merged
merged 1 commit into from
Jan 6, 2021
Merged

Upgrade axios to ^0.21 #71

merged 1 commit into from
Jan 6, 2021

Conversation

JosiahOne
Copy link
Contributor

@JosiahOne JosiahOne commented Jan 5, 2021

axios has a critical (server-side request forgery) security vulnerability affecting versions <0.21.1.

This is causing npm audit warnings when installing pm2. This PR allows 0.21.1 to be installed, mitigating the problem.

I wasn't sure how to run tests, to unfortunately that hasn't been done. I have no idea if this upgrade is stable.

@kerimkaan
Copy link

@Unitech Please confirm this PR and upgrade axios to 0.21.1 following infos: GHSA-4w2v-q235-vp99 https://www.npmjs.com/advisories/1594

@Unitech Unitech merged commit 9f824c0 into keymetrics:master Jan 6, 2021
@mashpie
Copy link

mashpie commented Jan 6, 2021

and please don't forget to publish to npm :)

@Unitech
Copy link
Member

Unitech commented Jan 6, 2021

Our CI did not managed to publish the package.

When:

git clone https://github.com/keymetrics/pm2-io-js-api.git
cd pm2-io-js-api
npm install

It fails with:

> @pm2/js-api@0.6.4 dist
> mkdir -p dist; browserify -s Keymetrics -r ./ | uglifyjs -c warnings=false -m > ./dist/keymetrics.es5.min.js

Parse error at 0:7247,20
exports.destroy = (() => {
                    ^
ERROR: Unexpected token: punc ())
    at JS_Parse_Error.get (eval at <anonymous> (/tmp/pm2-io-js-api/node_modules/uglify-js/tools/node.js:21:1), <anonymous>:73:23)
    at fatal (/tmp/pm2-io-js-api/node_modules/uglify-js/bin/uglifyjs:289:53)
    at run (/tmp/pm2-io-js-api/node_modules/uglify-js/bin/uglifyjs:233:9)
    at Socket.<anonymous> (/tmp/pm2-io-js-api/node_modules/uglify-js/bin/uglifyjs:166:9)
    at Socket.emit (node:events:388:22)
    at endReadableNT (node:internal/streams/readable:1295:12)
    at processTicksAndRejections (node:internal/process/task_queues:80:21)

I'm looking at it right now but if anyone has a suggestion that's welcome

@Unitech
Copy link
Member

Unitech commented Jan 6, 2021

ok published, the error was caused because of latest version of debug

@mashpie
Copy link

mashpie commented Jan 6, 2021

Thanks! Works for me like in Unitech/pm2#4937 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants