Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call super constructor in subclasses of WebApplicationException #29649

Merged

Conversation

froque
Copy link
Contributor

@froque froque commented May 17, 2024

Frameworks like Datadog dd-trace-java java agent inspect the known WebApplicationException and mark the exception as an HTTP 500, because that is the default for the non argument constructor.

Closes #29451

Frameworks like Datadog dd-trace-java java agent inspect the known WebApplicationException
and mark the exception as an HTTP 500, because that is the default for the
non argument constructor.

keycloak#29451

Signed-off-by: Filipe Roque <froque@premium-minds.com>
@froque froque requested a review from a team as a code owner May 17, 2024 13:49
@ahus1 ahus1 self-assigned this May 17, 2024
Copy link
Contributor

@ahus1 ahus1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this fix!

@ahus1 ahus1 enabled auto-merge (rebase) May 17, 2024 14:06
@ahus1
Copy link
Contributor

ahus1 commented May 17, 2024

@froque - if you want this to be included in a KC24 patch release, feel free to create a backport PR with the same change but target it towards the release/24.0 branch.

@ahus1 ahus1 merged commit e83f3af into keycloak:main May 17, 2024
63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CorsErrorResponseException prints wrong http code in the exception message
2 participants