Enhance StartDevCommandDistTest to detect problems with URI scheme on Windows #29593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pepo48
force-pushed
the
issue-29329
branch
2 times, most recently
from
0bb6b6a
to
d9d5955
Compare
Pepo48
changed the title
|
@vmuzikar this should be ready for a review. Thanks! |
vmuzikar
requested changes
May 22, 2024
There was a problem hiding this comment.
@Pepo48 Thank you for adding the test (the actual fix is no longer needed).
The test LGTM but I'm afraid we don't run it on Win in the CI. We could probably move the test to a test class that runs with Win.
2 tasks
… Windows * added a test - a Windows drive letter within URI can cause issues Related-to: keycloak#29329 Signed-off-by: Peter Zaoral <pzaoral@redhat.com>
Pepo48
changed the title
|
Sorry @vmuzikar, I forgot about that. I placed it to the StartDevCommandDistTest as I feel it's logically closest. Let me know if it can stay like that. Thanks. |
vmuzikar
approved these changes
May 22, 2024
tmorin
pushed a commit
to tmorin/keycloak
that referenced
this pull request
May 23, 2024
… Windows (keycloak#29593) * added a test - a Windows drive letter within URI can cause issues Related-to: keycloak#29329 Signed-off-by: Peter Zaoral <pzaoral@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related-to: #29329
Signed-off-by: Peter Zaoral pzaoral@redhat.com
Note:
#29329 was fixed earlier in #25333.