Fix CRL verification failing due to client cert not being in chain #29582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Micah Algard <micahalgard@gmail.com>
jonkoops
previously approved these changes
May 16, 2024
|
|
||
| @Drone | ||
| @PhantomJSBrowser | ||
| private WebDriver phantomJS; |
There was a problem hiding this comment.
Ideally we'd try to avoid introducing more PhantomJS (see #9979), but since AbstractX509AuthenticationTest is heavily based on it there is very little we can do.
There was a problem hiding this comment.
All x509 tests use the phantom, so I just followed the same idea. So when the x509 tests were changed to use another thing this one will be just one more test to change. Not doing anything here.
There was a problem hiding this comment.
Indeed, nothing that can be done about it until the testing team gets to it :)
There was a problem hiding this comment.
+1 , FYI. There is WiP by @Aboullos from QA team for refactoring of X.509 tests to make them get rid of PhantomJS
Closes keycloak#19853 Signed-off-by: rmartinc <rmartinc@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #19853
Just superseding PR #24760 to include a test with a single certificate with no CA trust anchor in the chain.