Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add empty Georgian translation for Weblate #29559

Merged
merged 1 commit into from
May 15, 2024
Merged

Conversation

NorwayFun
Copy link
Contributor

Initial 'adding empty files for themes' commit.

@jonkoops
Copy link
Contributor

Thanks for starting a PR to add translations. I think you should hold off until the translation is ready or your PR will be out here quite a while, feel free to open up a PR once you have the translations ready. We also require another native speaker to review any contributions, so keep that in mind thanks!

@jonkoops jonkoops closed this May 15, 2024
@jonkoops
Copy link
Contributor

Re-opening as per #9270 (reply in thread), wasn't aware of the previous discussion around this apologies.

@jonkoops jonkoops reopened this May 15, 2024
@jonkoops
Copy link
Contributor

@NorwayFun could you sign off on your commit?

@jonkoops jonkoops changed the title localization: Georgian translation Add empty Georgian translation for Weblate May 15, 2024
Copy link
Contributor

@ahus1 ahus1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that this is adding the language to theme.properties, which would make the translation show up in Keycloak already, although it is incomplete.

I'd rather revert those changes, and instead only keep the messages_ka.properties files which are required for Weblate to do the job.

In addition to this, please create GitHub issue first as outlined in the CONTRIBUTING.md and reference this in the commit. This allows us to track the conversation around this. Thanks!

@keycloak-github-bot
Copy link

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.x509.X509BrowserLoginTest#changeLocaleOnX509InfoPage

Keycloak CI - Java Distribution IT (windows-latest - temurin - 19)

java.lang.RuntimeException: Could not create statement
	at org.jboss.arquillian.junit.Arquillian.methodBlock(Arquillian.java:307)
	at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
...

Report flaky test

Copy link

@keycloak-github-bot keycloak-github-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@ahus1
Copy link
Contributor

ahus1 commented May 15, 2024

@NorwayFun - I updated this PR to remove the theme.properties as agreed in the discussion.

The new messages_ka.properties are now only present in the resources-community, I removed them from the resources folder.

To clarify: Which themes do you plan to translate - all of Keycloak? Only some themes? This PR now contains 3 themes out of the total 6 themes.

image

Copy link

@keycloak-github-bot keycloak-github-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
Copy link

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.federation.ldap.LDAPUserLoginTest#loginLDAPUserCredentialVaultAuthenticationNoneEncryptionNone

Keycloak CI - Java Distribution IT (windows-latest - temurin - 19)

org.openqa.selenium.TimeoutException: 
java.net.SocketTimeoutException: Read timed out
Build info: version: '3.14.0', revision: 'aacccce0', time: '2018-08-02T20:19:58.91Z'
System info: host: 'fv-az836-427', ip: '10.1.0.26', os.name: 'Windows Server 2022', os.arch: 'amd64', os.version: '10.0', java.version: '19.0.2'
Driver info: driver.version: HtmlUnitDriver
...

Report flaky test

@NorwayFun
Copy link
Contributor Author

@NorwayFun - I updated this PR to remove the theme.properties as agreed in the discussion.

The new messages_ka.properties are now only present in the resources-community, I removed them from the resources folder.

To clarify: Which themes do you plan to translate - all of Keycloak? Only some themes? This PR now contains 3 themes out of the total 6 themes.

image

Ineresting.. cloned whole repo and searched for .properties files in themes dir and made _ka files for every file.
Is there anything else? Lets make it for everything, I'll translate at least minimal amount of strings in every file so build will not fail.

@ahus1
Copy link
Contributor

ahus1 commented May 15, 2024

@NorwayFun - I saw previous files, I at first I thought they were in the wrong target folder, now I realized there were in the correct place. Sorry for the confusion.

@ahus1 ahus1 enabled auto-merge (squash) May 15, 2024 15:23
Copy link
Contributor

@jonkoops jonkoops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good

Co-authored-by: Alexander Schwartz <aschwart@redhat.com>
Signed-off-by: Alexander Schwartz <aschwart@redhat.com>
Signed-off-by: norwayfun <temuri.doghonadze@gmail.com>
@ahus1 ahus1 merged commit 5194216 into keycloak:main May 15, 2024
67 checks passed
@ahus1
Copy link
Contributor

ahus1 commented May 15, 2024

@NorwayFun - as this PR is now merged, Georgian now appeared as a language in Weblate.

For translations in Keycloak, it is common practice that a second native speaker reviews translations. This helps to ensure the quality of the translation, and we have a similar practice for code changes.

For incremental translations in Weblate, this would usually be the maintainer of a language. As this is the initial translation, and you are the maintainer of that language, I ask you to find yourself a second person who is a native speaker.

That person would then either review the translations in Weblate, or review the translated files in the Keycloak repository the moment before we add the Georgian language code to the theme.properties files - this is up for the two of you to decide.

Please let me know if you think this can work, if you see obstacles and if you would like someone to help you with that. Thanks!

@NorwayFun
Copy link
Contributor Author

@NorwayFun - as this PR is now merged, Georgian now appeared as a language in Weblate.

For translations in Keycloak, it is common practice that a second native speaker reviews translations. This helps to ensure the quality of the translation, and we have a similar practice for code changes.

For incremental translations in Weblate, this would usually be the maintainer of a language. As this is the initial translation, and you are the maintainer of that language, I ask you to find yourself a second person who is a native speaker.

That person would then either review the translations in Weblate, or review the translated files in the Keycloak repository the moment before we add the Georgian language code to the theme.properties files - this is up for the two of you to decide.

Please let me know if you think this can work, if you see obstacles and if you would like someone to help you with that. Thanks!

Hi!
მადლობა! Thank you!
Me and my friend are in the middle of translating LibreOffice now. After finishing it (And man it's taking a lot) I'll try to convince her to do proofreading for me. Most likely we'll reach for you to assign her as proofreader.

@ahus1
Copy link
Contributor

ahus1 commented May 16, 2024

Great, let's proceed as you describe. There is also the Keycloak user mailing list, and you might find a volunteer there to help with a review.

@NorwayFun
Copy link
Contributor Author

@ahus1 I think support can already be added. There is only bigger one left to be translated, but if sync process from weblate is automated, it makes no sense to wait until I'll finish it (3k strings with 160k chars are no joke :) )

About volunteers/contributors, good luck finding even one :)

Anything else is needed to be done from my side, other than continuing translation, please?

@ahus1
Copy link
Contributor

ahus1 commented Jun 3, 2024

I see that all components except for the Admin UI are now translated one the next PR #30044 is merged - see the image below.

So I'd say we're good to add the Georgian language to all themes except for the Admin UI. When doing this, all these translations need to be reviewed by a second native speaker. Do you have a friend or partner who can do this? You could also consider looking for other Georgian users on the Keycloak Users mailing list. When creating that PR, you should also update the translation.md file and add the Georgian language to the list of languages managed in Weblate.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants