-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add empty Georgian translation for Weblate #29559
Conversation
Thanks for starting a PR to add translations. I think you should hold off until the translation is ready or your PR will be out here quite a while, feel free to open up a PR once you have the translations ready. We also require another native speaker to review any contributions, so keep that in mind thanks! |
Re-opening as per #9270 (reply in thread), wasn't aware of the previous discussion around this apologies. |
@NorwayFun could you sign off on your commit? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that this is adding the language to theme.properties
, which would make the translation show up in Keycloak already, although it is incomplete.
I'd rather revert those changes, and instead only keep the messages_ka.properties
files which are required for Weblate to do the job.
In addition to this, please create GitHub issue first as outlined in the CONTRIBUTING.md
and reference this in the commit. This allows us to track the conversation around this. Thanks!
Unreported flaky test detectedIf the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR. org.keycloak.testsuite.x509.X509BrowserLoginTest#changeLocaleOnX509InfoPageKeycloak CI - Java Distribution IT (windows-latest - temurin - 19)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unreported flaky test detected, please review
@NorwayFun - I updated this PR to remove the The new To clarify: Which themes do you plan to translate - all of Keycloak? Only some themes? This PR now contains 3 themes out of the total 6 themes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unreported flaky test detected, please review
Unreported flaky test detectedIf the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR. org.keycloak.testsuite.federation.ldap.LDAPUserLoginTest#loginLDAPUserCredentialVaultAuthenticationNoneEncryptionNoneKeycloak CI - Java Distribution IT (windows-latest - temurin - 19)
|
Ineresting.. cloned whole repo and searched for .properties files in themes dir and made _ka files for every file. |
@NorwayFun - I saw previous files, I at first I thought they were in the wrong target folder, now I realized there were in the correct place. Sorry for the confusion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good
Co-authored-by: Alexander Schwartz <aschwart@redhat.com> Signed-off-by: Alexander Schwartz <aschwart@redhat.com> Signed-off-by: norwayfun <temuri.doghonadze@gmail.com>
@NorwayFun - as this PR is now merged, Georgian now appeared as a language in Weblate. For translations in Keycloak, it is common practice that a second native speaker reviews translations. This helps to ensure the quality of the translation, and we have a similar practice for code changes. For incremental translations in Weblate, this would usually be the maintainer of a language. As this is the initial translation, and you are the maintainer of that language, I ask you to find yourself a second person who is a native speaker. That person would then either review the translations in Weblate, or review the translated files in the Keycloak repository the moment before we add the Georgian language code to the Please let me know if you think this can work, if you see obstacles and if you would like someone to help you with that. Thanks! |
Hi! |
Great, let's proceed as you describe. There is also the Keycloak user mailing list, and you might find a volunteer there to help with a review. |
@ahus1 I think support can already be added. There is only bigger one left to be translated, but if sync process from weblate is automated, it makes no sense to wait until I'll finish it (3k strings with 160k chars are no joke :) ) About volunteers/contributors, good luck finding even one :) Anything else is needed to be done from my side, other than continuing translation, please? |
I see that all components except for the Admin UI are now translated one the next PR #30044 is merged - see the image below. So I'd say we're good to add the Georgian language to all themes except for the Admin UI. When doing this, all these translations need to be reviewed by a second native speaker. Do you have a friend or partner who can do this? You could also consider looking for other Georgian users on the Keycloak Users mailing list. When creating that PR, you should also update the |
Initial 'adding empty files for themes' commit.