-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow migration of non-persistent sessions to persistent sessions #29377
Allow migration of non-persistent sessions to persistent sessions #29377
Conversation
@mhajas - this is still missing a test. I'd be happy for your feedback if this goes into the right direction. Thanks! |
fc33145
to
32fb237
Compare
...pan/src/main/java/org/keycloak/models/sessions/infinispan/PersistentUserSessionProvider.java
Show resolved
Hide resolved
54cfca5
to
e6929c5
Compare
…ing upgrades Closes keycloak#29375 Signed-off-by: Alexander Schwartz <aschwart@redhat.com>
e6929c5
to
87eb74d
Compare
docs/documentation/upgrading/topics/changes/changes-25_0_0.adoc
Outdated
Show resolved
Hide resolved
docs/documentation/upgrading/topics/changes/changes-25_0_0.adoc
Outdated
Show resolved
Hide resolved
...pan/src/main/java/org/keycloak/models/sessions/infinispan/PersistentUserSessionProvider.java
Outdated
Show resolved
Hide resolved
Closes keycloak#29375 Signed-off-by: Alexander Schwartz <aschwart@redhat.com>
f24c6ee
to
17cbce9
Compare
Closes keycloak#29375 Signed-off-by: Alexander Schwartz <aschwart@redhat.com>
17cbce9
to
e105dba
Compare
This will be quite useful to have! |
@thomasdarimont - thank you for the suggestion. I think this would be a good follow-up PR. I will need some advice on how to use the estimate counting to avoid an expensive operation. I added it as an optional task to #28265 |
docs/documentation/upgrading/topics/changes/changes-25_0_0.adoc
Outdated
Show resolved
Hide resolved
docs/documentation/upgrading/topics/changes/changes-25_0_0.adoc
Outdated
Show resolved
Hide resolved
docs/documentation/upgrading/topics/changes/changes-25_0_0.adoc
Outdated
Show resolved
Hide resolved
Closes keycloak#29375 Signed-off-by: Alexander Schwartz <aschwart@redhat.com>
@ryanemerson - I've updated the docs, please re-review. Thanks! |
...pan/src/main/java/org/keycloak/models/sessions/infinispan/PersistentUserSessionProvider.java
Show resolved
Hide resolved
...pan/src/main/java/org/keycloak/models/sessions/infinispan/PersistentUserSessionProvider.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unreported flaky test detected, please review
Unreported flaky test detectedIf the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR. org.keycloak.testsuite.model.session.UserSessionPersisterProviderTest#testMigrateSessionKeycloak CI - Store Model Tests
|
Closes keycloak#29375 Signed-off-by: Alexander Schwartz <aschwart@redhat.com>
Unreported flaky test detectedIf the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR. org.keycloak.testsuite.model.session.UserSessionPersisterProviderTest#testMigrateSessionKeycloak CI - Store Model Tests
org.keycloak.testsuite.model.session.SessionTimeoutsTest#testOfflineUserClientIdleTimeoutSmallerThanSessionNoRefreshKeycloak CI - Store Model Tests
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unreported flaky test detected, please review
@dbubenheim - we're currently working on persistent sessions, see discussion #28271 over there. Given our previous discussion, I assume you might be interested in that feature as it IMHO has the potential to simplify your current setup. I'd hope we get this change into main before KC25 is released. KC25 is currently scheduled for end of May, and I wonder if you would be interested and have the time to test this migration with your setup before or after our release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @ahus1! This is a great addition for people that use some sort of persistence in their current setup
Closes #29375