quarkus-next: keystore/trust store type is determined based on file extension #29373

Pepo48 · 2024-05-08T07:53:01Z

reflect the new default truststore/keystore format mechanism, which causes some FipsDistTests to fail

Closes: #29207

shawkins

LGTM, thanks @Pepo48

vmuzikar · 2024-05-10T09:00:38Z

@Pepo48 I took the liberty of changing the PR name to better reflect the changes.

Tests seem to be failing due though. But I assume we're blocked by #29438 in any case.

Pepo48 · 2024-05-10T09:05:01Z

@vmuzikar yes, #29438 needs to be merged first and then I can rebase this one in order to make the CI work.

Pepo48 · 2024-05-10T10:07:12Z

@vmuzikar given the PR name change I would then definitely split it into two separate PRs since d41a975238c57c72add4cd275f02293b7d149961 is now kinda unrelated.

vmuzikar · 2024-05-10T10:15:16Z

@Pepo48 Works for me 👍

Pepo48 · 2024-05-16T07:09:50Z

I split the PRs, here's the other one: #29584

I think that both are ready to be merged into the quarkus-next branch at this point.

cc: @vmuzikar

vmuzikar

Changes LGTM but I wonder what can we do about release notes, it's essentially a breaking change that the type is now assumed from the file extension. Maybe we could start release notes for 26?

Pepo48 · 2024-05-20T10:06:22Z

@vmuzikar should it be part of this commit or should I create a follow-up that will go directly to the main branch?

vmuzikar · 2024-05-20T10:44:45Z

I'd keep it in a single PR – this one. IMHO should not go to main as the code change is not in main yet. Once KC 25 is released, we can merge changes in quarkus-next to main together with upgrade to latest Quarkus.

Pepo48 · 2024-05-22T17:32:48Z

@vmuzikar I added a release note as you suggested. PTAL. Thanks!

vmuzikar

@Pepo48 Thank you for adding the release notes. I realized I said "release notes" but it's more of a breaking change that should be in the upgrading guide. Could you please move it there? Sorry about that.

I also noticed this PR now includes the version bump from bot. Can you please remove it?

Pepo48 · 2024-05-23T07:40:16Z

@vmuzikar I moved it, can you, please, check it again? Thanks!

vmuzikar

LGTM, thank you!

…xtension (#29373) * quarkus-next: keystore/trust store type is determined based on file extension * fixes FipsDistTest#testHttpsPkcs12TrustStoreInNonApprovedMode Closes: #29207 Signed-off-by: Peter Zaoral <pzaoral@redhat.com> * quarkus-next: keystore/trust store type is determined based on file extension * fixes FipsDistTest#testHttpsPkcs12TrustStoreInNonApprovedMode Closes: #29207 Signed-off-by: Peter Zaoral <pzaoral@redhat.com> --------- Signed-off-by: Peter Zaoral <pzaoral@redhat.com>

Pepo48 changed the base branch from main to quarkus-next May 9, 2024 20:16

Pepo48 marked this pull request as ready for review May 9, 2024 20:16

Pepo48 requested review from a team as code owners May 9, 2024 20:16

keycloak-github-bot bot added team/cloud-native labels May 9, 2024

shawkins approved these changes May 9, 2024

View reviewed changes

github-actions bot force-pushed the quarkus-next branch from 475920f to 5160237 Compare May 10, 2024 00:10

vmuzikar changed the title ~~Upgrade to Quarkus 3.9/next LTS~~ quarkus-next: keystore/trust store type is determined based on file extension May 10, 2024

github-actions bot force-pushed the quarkus-next branch 6 times, most recently from 7021872 to 54da7f7 Compare May 16, 2024 00:10

Pepo48 force-pushed the quarkus39 branch from d41a975 to aa72c1c Compare May 16, 2024 07:05

github-actions bot force-pushed the quarkus-next branch 4 times, most recently from 86ac4e3 to fed9b73 Compare May 20, 2024 00:10

vmuzikar reviewed May 20, 2024

View reviewed changes

github-actions bot force-pushed the quarkus-next branch 2 times, most recently from d003a64 to 200671f Compare May 22, 2024 00:10

Pepo48 force-pushed the quarkus39 branch from aa72c1c to 9a3f3f3 Compare May 22, 2024 17:28

github-actions bot force-pushed the quarkus-next branch from 200671f to 1d65bc8 Compare May 23, 2024 00:10

vmuzikar requested changes May 23, 2024

View reviewed changes

Pepo48 force-pushed the quarkus39 branch from 9a3f3f3 to 883214c Compare May 23, 2024 07:38

Pepo48 force-pushed the quarkus39 branch 2 times, most recently from 9758ce4 to 4b1e616 Compare May 23, 2024 07:49

vmuzikar approved these changes May 23, 2024

View reviewed changes

vmuzikar merged this pull request into keycloak:quarkus-next May 23, 2024
59 of 61 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

quarkus-next: keystore/trust store type is determined based on file extension #29373

quarkus-next: keystore/trust store type is determined based on file extension #29373

Pepo48 commented May 8, 2024 •

edited

shawkins left a comment

vmuzikar commented May 10, 2024 •

edited

Pepo48 commented May 10, 2024

Pepo48 commented May 10, 2024

vmuzikar commented May 10, 2024

Pepo48 commented May 16, 2024

vmuzikar left a comment

Pepo48 commented May 20, 2024

vmuzikar commented May 20, 2024

Pepo48 commented May 22, 2024

vmuzikar left a comment

Pepo48 commented May 23, 2024

vmuzikar left a comment

quarkus-next: keystore/trust store type is determined based on file extension #29373

quarkus-next: keystore/trust store type is determined based on file extension #29373

Conversation

Pepo48 commented May 8, 2024 • edited

shawkins left a comment

Choose a reason for hiding this comment

vmuzikar commented May 10, 2024 • edited

Pepo48 commented May 10, 2024

Pepo48 commented May 10, 2024

vmuzikar commented May 10, 2024

Pepo48 commented May 16, 2024

vmuzikar left a comment

Choose a reason for hiding this comment

Pepo48 commented May 20, 2024

vmuzikar commented May 20, 2024

Pepo48 commented May 22, 2024

vmuzikar left a comment

Choose a reason for hiding this comment

Pepo48 commented May 23, 2024

vmuzikar left a comment

Choose a reason for hiding this comment

Pepo48 commented May 8, 2024 •

edited

vmuzikar commented May 10, 2024 •

edited