Do not remove previous refresh token for federated identity #29109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedroigor
reviewed
Apr 26, 2024
| // like in OIDCIdentityProvider.exchangeStoredToken() | ||
| // we shouldn't override the refresh token if it is null in the context and not null in the DB | ||
| // as for google IDP it will be lost forever | ||
| if (federatedIdentityModel.getToken() != null && !(context.getIdp() instanceof SAMLIdentityProvider)) { |
There was a problem hiding this comment.
I think it is better/safer if we check if the idp is a ExchangeTokenToIdentityProviderToken. It will catch both OIDC and OAuth based brokers while at the same time excluding SAML as we don't support internal to external token exchanges for SAML.
This was referenced Apr 26, 2024
sguilhen
force-pushed
the
25815-fed-identity-refresh-token
branch
2 times, most recently
from
b80d1f1
to
76f6d22
Compare
sguilhen
changed the title
Signed-off-by: Geoffrey Fourmis <geoffrey.fourmis@gmail.com>
sguilhen
force-pushed
the
25815-fed-identity-refresh-token
branch
from
76f6d22
to
13b77fc
Compare
sguilhen
force-pushed
the
25815-fed-identity-refresh-token
branch
2 times, most recently
from
407be02
to
e3229dc
Compare
… not an AccessTokenResponse. - also adds a test for the refresh token on first login scenario. Signed-off-by: Stefan Guilhen <sguilhen@redhat.com>
sguilhen
force-pushed
the
25815-fed-identity-refresh-token
branch
from
e3229dc
to
8278d8f
Compare
pedroigor
approved these changes
Apr 30, 2024
![keycloak-github-bot[bot]](https://avatars.githubusercontent.com/u/4921466?s=60&v=4){kind=small}
Unreported flaky test detectedIf the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR. org.keycloak.testsuite.x509.X509BrowserCRLTest#loginFailedWithIntermediateRevocationListFromHttpKeycloak CI - FIPS IT (strict) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #25815