New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Encode realm name in console URIs #29102
Conversation
Before this fix console uris (including the client redirect uris) did not contain the url encoded realm name and therefore were invalid. Fixes keycloak#25807 Signed-off-by: Philip Sanetra <code@psanetra.de>
I have fixed also the account v3. It was just a decode in the path of the router. Please @keycloak/ui take a look just in case. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just wondering if the URLs could be done with less repetition.
services/src/main/java/org/keycloak/services/managers/RealmManager.java
Outdated
Show resolved
Hide resolved
services/src/main/java/org/keycloak/services/managers/RealmManager.java
Outdated
Show resolved
Hide resolved
Closes keycloak#25807 Signed-off-by: rmartinc <rmartinc@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Closes #25807
This probably also closes #26108. I'll take a look but I think that with this the realm is properly checked in name and id.
The PR encodes the URLs generated when a realm is created. It also decodes the issuer to obtain the realm that was previously encoded. Tests added.
Maybe there are more issues about spaces in realms but the idea is managing them one by one. With this PR at least the realm is created and it's functional with the admin console. I'm going to file a new bug for the account console. The v2 one worked OK but v3 is failing.