Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use cache.compute() method to improve the replace retry loop #29081

Merged
merged 1 commit into from Apr 29, 2024
Merged

Use cache.compute() method to improve the replace retry loop #29081

merged 1 commit into from Apr 29, 2024

Conversation

pruivo
Copy link
Contributor

@pruivo pruivo commented Apr 25, 2024

Closes #29073

@pruivo pruivo requested a review from a team as a code owner April 25, 2024 11:46
@ahus1 ahus1 self-assigned this Apr 25, 2024
This was referenced Apr 25, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
ahus1
ahus1 reviewed Apr 25, 2024
View reviewed changes
Copy link
Contributor

@ahus1 ahus1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @pruivo - thank you for this PR. I have another question about serialization ... please see below.

...nfinispan/src/main/java/org/keycloak/models/sessions/infinispan/changes/ReplaceFunction.java Show resolved Hide resolved
@pruivo
Use cache.compute() method to improve the replace retry loop
257bd42 
Closes keycloak#29073

Signed-off-by: Pedro Ruivo <pruivo@redhat.com>
@pruivo pruivo requested a review from a team as a code owner April 27, 2024 16:54
ahus1
ahus1 approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@ahus1 ahus1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this change! I've reviewed it, and also tested it with a 3-node deployment on OpenShift with remote debugging to inspect the code, where it worked as expected.

@ahus1 ahus1 merged commit 17a700b into keycloak:main Apr 29, 2024
70 checks passed
@pruivo pruivo deleted the t_29073 branch April 29, 2024 10:39
@mhajas mhajas mentioned this pull request Apr 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahus1 ahus1 ahus1 approved these changes

Assignees

@ahus1 ahus1

Labels
flaky-test team/cloud-native
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use cache.compute() method to improve the replace retry loop
2 participants
@pruivo @ahus1