External Infinispan as cache - Part 3 #29071

pruivo · 2024-04-25T06:45:42Z

Implementation of UserLoginFailureProvider using remote caches only.

keycloak-github-bot

Unreported flaky test detected, please review

keycloak-github-bot · 2024-05-06T10:36:04Z

jakarta.ws.rs.InternalServerErrorException: HTTP 500 Internal Server Error
	at org.jboss.resteasy.client.jaxrs.internal.ClientInvocation.handleErrorStatus(ClientInvocation.java:250)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.extractors.DefaultEntityExtractorFactory$3.extractEntity(DefaultEntityExtractorFactory.java:41)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.ClientInvoker.invokeSync(ClientInvoker.java:136)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.ClientInvoker.invoke(ClientInvoker.java:103)
...

Report flaky test

keycloak-github-bot

Unreported flaky test detected, please review

keycloak-github-bot · 2024-05-06T12:00:03Z

jakarta.ws.rs.InternalServerErrorException: HTTP 500 Internal Server Error
	at org.jboss.resteasy.client.jaxrs.internal.ClientInvocation.handleErrorStatus(ClientInvocation.java:250)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.extractors.DefaultEntityExtractorFactory$3.extractEntity(DefaultEntityExtractorFactory.java:41)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.ClientInvoker.invokeSync(ClientInvoker.java:136)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.ClientInvoker.invoke(ClientInvoker.java:103)
...

Report flaky test

pruivo · 2024-05-06T17:26:15Z

Disabled the following tests because we are unable to control time in the docker container:

org.keycloak.testsuite.model.AuthenticationSessionProviderTest#testExpiredAuthSessions
org.keycloak.testsuite.oauth.AccessTokenTest#accessTokenCodeExpired

Modified the following test due to the async nature of hot rod client events

org.keycloak.testsuite.model.UserSessionProviderTest#testRemoveUserSessionsByRealm

keycloak-github-bot · 2024-05-07T18:23:43Z

jakarta.ws.rs.InternalServerErrorException: HTTP 500 Internal Server Error
	at org.jboss.resteasy.client.jaxrs.internal.ClientInvocation.handleErrorStatus(ClientInvocation.java:250)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.extractors.DefaultEntityExtractorFactory$3.extractEntity(DefaultEntityExtractorFactory.java:41)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.ClientInvoker.invokeSync(ClientInvoker.java:136)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.ClientInvoker.invoke(ClientInvoker.java:103)
...

Report flaky test

keycloak-github-bot

Unreported flaky test detected, please review

keycloak-github-bot

Unreported flaky test detected, please review

keycloak-github-bot · 2024-05-08T11:05:37Z

jakarta.ws.rs.InternalServerErrorException: HTTP 500 Internal Server Error
	at org.jboss.resteasy.client.jaxrs.internal.ClientInvocation.handleErrorStatus(ClientInvocation.java:250)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.extractors.DefaultEntityExtractorFactory$3.extractEntity(DefaultEntityExtractorFactory.java:41)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.ClientInvoker.invokeSync(ClientInvoker.java:136)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.ClientInvoker.invoke(ClientInvoker.java:103)
...

Report flaky test

keycloak-github-bot

Unreported flaky test detected, please review

keycloak-github-bot · 2024-05-08T12:19:05Z

jakarta.ws.rs.InternalServerErrorException: HTTP 500 Internal Server Error
	at org.jboss.resteasy.client.jaxrs.internal.ClientInvocation.handleErrorStatus(ClientInvocation.java:250)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.extractors.DefaultEntityExtractorFactory$3.extractEntity(DefaultEntityExtractorFactory.java:41)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.ClientInvoker.invokeSync(ClientInvoker.java:136)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.ClientInvoker.invoke(ClientInvoker.java:103)
...

Report flaky test

ahus1

Thank you for the PR! See below for two comment. Thanks!

ahus1 · 2024-05-08T16:48:32Z

...tests/base/src/test/java/org/keycloak/testsuite/model/AuthenticationSessionProviderTest.java

@@ -212,10 +214,12 @@ public void testAuthenticationSessionRestart(KeycloakSession session) {
    @Test
    @ModelTest
    public void testExpiredAuthSessions(KeycloakSession session) {
+        // for some reason, Profile is always null.


Could you please try some thing along the lines of the following as it reveals more of the why?
Also the comment "for some reason..." is outdated, as we now know the reason (ProfileAssume doesn't work in ModelTests...)

assumeFalse(Profile.isFeatureEnabled(Profile.Feature.REMOTE_CACHE));

I'm pretty sure Profile.isFeatureEnabled is throwing an NPE too. Anyway, I've applied your suggestion.

ahus1 · 2024-05-08T16:51:24Z

...rquillian/tests/base/src/test/java/org/keycloak/testsuite/model/UserSessionProviderTest.java

+        var user2 = session.users().getUserByUsername(realm, "user2");
+
+        // TODO! [pruivo] to be removed when the session cache is remote only
+        // TODO! the Hot Rod events are async


Is that still a TODO? With eventuallyEquals, shouldn't that just work?

The eventuallyEquals can be removed after the UserSessionProvider is implemented to use the remote cache. Those TODOs are here to remind me to revert the code.

Implementation of UserLoginFailureProvider using remote caches only. Closes keycloak#28754 Signed-off-by: Pedro Ruivo <pruivo@redhat.com>

keycloak-github-bot · 2024-05-08T21:44:09Z

jakarta.ws.rs.InternalServerErrorException: HTTP 500 Internal Server Error
	at org.jboss.resteasy.client.jaxrs.internal.ClientInvocation.handleErrorStatus(ClientInvocation.java:250)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.extractors.DefaultEntityExtractorFactory$3.extractEntity(DefaultEntityExtractorFactory.java:41)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.ClientInvoker.invokeSync(ClientInvoker.java:136)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.ClientInvoker.invoke(ClientInvoker.java:103)
...

Report flaky test

keycloak-github-bot

Unreported flaky test detected, please review

keycloak-github-bot bot added the flaky-test label Apr 25, 2024

pruivo force-pushed the t_28754 branch from 8d4a980 to 25ef45f Compare April 29, 2024 16:00

pruivo marked this pull request as ready for review April 30, 2024 17:52

pruivo requested review from a team as code owners April 30, 2024 17:52

keycloak-github-bot bot added team/cloud-native team/core-clients team/core-iam labels Apr 30, 2024

ahus1 self-assigned this May 3, 2024

pruivo force-pushed the t_28754 branch from 2d351d6 to 722b3fa Compare May 6, 2024 09:28

keycloak-github-bot bot reviewed May 6, 2024

View reviewed changes

pruivo force-pushed the t_28754 branch from 722b3fa to 7508e65 Compare May 6, 2024 10:52

keycloak-github-bot bot reviewed May 6, 2024

View reviewed changes

pruivo force-pushed the t_28754 branch from 7508e65 to 9ed64a3 Compare May 6, 2024 17:21

pruivo force-pushed the t_28754 branch 7 times, most recently from b3ba665 to ca9b44f Compare May 7, 2024 17:15

keycloak-github-bot bot reviewed May 7, 2024

View reviewed changes

pruivo force-pushed the t_28754 branch from ca9b44f to 9b6338e Compare May 8, 2024 09:58

keycloak-github-bot bot reviewed May 8, 2024

View reviewed changes

pruivo force-pushed the t_28754 branch from 9b6338e to 8f8cc25 Compare May 8, 2024 11:12

keycloak-github-bot bot reviewed May 8, 2024

View reviewed changes

ahus1 requested changes May 8, 2024

View reviewed changes

External Infinispan as cache - Part 3

84440bd

Implementation of UserLoginFailureProvider using remote caches only. Closes keycloak#28754 Signed-off-by: Pedro Ruivo <pruivo@redhat.com>

pruivo force-pushed the t_28754 branch from 8f8cc25 to 84440bd Compare May 8, 2024 20:36

This was referenced May 8, 2024

Flaky test: org.keycloak.testsuite.admin.concurrency.ConcurrencyTest#createRemoveClient #29289

Open

Flaky test: org.keycloak.testsuite.admin.concurrency.ConcurrencyTest#createClient #29290

Open

keycloak-github-bot bot reviewed May 8, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

External Infinispan as cache - Part 3 #29071

External Infinispan as cache - Part 3 #29071

pruivo commented Apr 25, 2024 •

edited

keycloak-github-bot bot left a comment

keycloak-github-bot bot commented May 6, 2024

keycloak-github-bot bot left a comment

keycloak-github-bot bot commented May 6, 2024

pruivo commented May 6, 2024

keycloak-github-bot bot commented May 7, 2024

keycloak-github-bot bot left a comment

keycloak-github-bot bot left a comment

keycloak-github-bot bot commented May 8, 2024

keycloak-github-bot bot left a comment

keycloak-github-bot bot commented May 8, 2024

ahus1 left a comment

ahus1 May 8, 2024

pruivo May 8, 2024

ahus1 May 8, 2024

pruivo May 8, 2024

keycloak-github-bot bot commented May 8, 2024

keycloak-github-bot bot left a comment

External Infinispan as cache - Part 3 #29071

Are you sure you want to change the base?

External Infinispan as cache - Part 3 #29071

Conversation

pruivo commented Apr 25, 2024 • edited

keycloak-github-bot bot left a comment

Choose a reason for hiding this comment

keycloak-github-bot bot commented May 6, 2024

Unreported flaky test detected

org.keycloak.testsuite.oid4vc.issuance.signing.OID4VCIssuerEndpointTest#testGetCredentialOfferUriUnsupportedCredential

org.keycloak.testsuite.oid4vc.issuance.signing.OID4VCIssuerEndpointTest#testGetCredentialOfferUriInvalidToken

org.keycloak.testsuite.oid4vc.issuance.signing.OID4VCIssuerEndpointTest#testRequestCredential

org.keycloak.testsuite.oid4vc.issuance.signing.OID4VCIssuerEndpointTest#testGetCredentialOfferUriUnauthorized

org.keycloak.testsuite.oid4vc.issuance.signing.OID4VCIssuerEndpointTest#testGetCredentialOfferUnauthorized

org.keycloak.testsuite.oid4vc.issuance.signing.OID4VCIssuerEndpointTest#testRequestCredentialInvalidToken

org.keycloak.testsuite.oid4vc.issuance.signing.OID4VCIssuerEndpointTest#testRequestCredentialUnauthorized

org.keycloak.testsuite.oid4vc.issuance.signing.OID4VCIssuerEndpointTest#testCredentialIssuance

org.keycloak.testsuite.oid4vc.issuance.signing.OID4VCIssuerEndpointTest#testGetCredentialOfferWithoutNonce

org.keycloak.testsuite.oid4vc.issuance.signing.OID4VCIssuerEndpointTest#testGetCredentialOffer

org.keycloak.testsuite.oid4vc.issuance.signing.OID4VCIssuerEndpointTest#testGetCredentialOfferWithABrokenNote

org.keycloak.testsuite.oid4vc.issuance.signing.OID4VCIssuerEndpointTest#testGetCredentialOfferURI

org.keycloak.testsuite.oid4vc.issuance.signing.OID4VCIssuerEndpointTest#testGetCredentialOfferWithoutAPreparedOffer

org.keycloak.testsuite.oid4vc.issuance.signing.OID4VCIssuerEndpointTest#testRequestCredentialUnsupportedFormat

org.keycloak.testsuite.oid4vc.issuance.signing.OID4VCIssuerEndpointTest#testRequestCredentialUnsupportedCredential

keycloak-github-bot bot left a comment

Choose a reason for hiding this comment

keycloak-github-bot bot commented May 6, 2024

Unreported flaky test detected

org.keycloak.testsuite.oid4vc.issuance.signing.OID4VCIssuerEndpointTest#testGetCredentialOfferUriUnsupportedCredential

org.keycloak.testsuite.oid4vc.issuance.signing.OID4VCIssuerEndpointTest#testGetCredentialOfferUriInvalidToken

org.keycloak.testsuite.oid4vc.issuance.signing.OID4VCIssuerEndpointTest#testRequestCredential

org.keycloak.testsuite.oid4vc.issuance.signing.OID4VCIssuerEndpointTest#testGetCredentialOfferUriUnauthorized

org.keycloak.testsuite.oid4vc.issuance.signing.OID4VCIssuerEndpointTest#testGetCredentialOfferUnauthorized

org.keycloak.testsuite.oid4vc.issuance.signing.OID4VCIssuerEndpointTest#testRequestCredentialInvalidToken

org.keycloak.testsuite.oid4vc.issuance.signing.OID4VCIssuerEndpointTest#testRequestCredentialUnauthorized

org.keycloak.testsuite.oid4vc.issuance.signing.OID4VCIssuerEndpointTest#testCredentialIssuance

org.keycloak.testsuite.oid4vc.issuance.signing.OID4VCIssuerEndpointTest#testGetCredentialOfferWithoutNonce

org.keycloak.testsuite.oid4vc.issuance.signing.OID4VCIssuerEndpointTest#testGetCredentialOffer

org.keycloak.testsuite.oid4vc.issuance.signing.OID4VCIssuerEndpointTest#testGetCredentialOfferWithABrokenNote

org.keycloak.testsuite.oid4vc.issuance.signing.OID4VCIssuerEndpointTest#testGetCredentialOfferURI

org.keycloak.testsuite.oid4vc.issuance.signing.OID4VCIssuerEndpointTest#testGetCredentialOfferWithoutAPreparedOffer

org.keycloak.testsuite.oid4vc.issuance.signing.OID4VCIssuerEndpointTest#testRequestCredentialUnsupportedFormat

org.keycloak.testsuite.oid4vc.issuance.signing.OID4VCIssuerEndpointTest#testRequestCredentialUnsupportedCredential

pruivo commented May 6, 2024

keycloak-github-bot bot commented May 7, 2024

Unreported flaky test detected

org.keycloak.testsuite.oid4vc.issuance.signing.OID4VCIssuerEndpointTest#testGetCredentialOfferUriUnsupportedCredential

org.keycloak.testsuite.oid4vc.issuance.signing.OID4VCIssuerEndpointTest#testGetCredentialOfferUriInvalidToken

org.keycloak.testsuite.oid4vc.issuance.signing.OID4VCIssuerEndpointTest#testRequestCredential

org.keycloak.testsuite.oid4vc.issuance.signing.OID4VCIssuerEndpointTest#testGetCredentialOfferUriUnauthorized

org.keycloak.testsuite.oid4vc.issuance.signing.OID4VCIssuerEndpointTest#testGetCredentialOfferUnauthorized

org.keycloak.testsuite.oid4vc.issuance.signing.OID4VCIssuerEndpointTest#testRequestCredentialInvalidToken

org.keycloak.testsuite.oid4vc.issuance.signing.OID4VCIssuerEndpointTest#testRequestCredentialUnauthorized

org.keycloak.testsuite.oid4vc.issuance.signing.OID4VCIssuerEndpointTest#testCredentialIssuance

org.keycloak.testsuite.oid4vc.issuance.signing.OID4VCIssuerEndpointTest#testGetCredentialOfferWithoutNonce

org.keycloak.testsuite.oid4vc.issuance.signing.OID4VCIssuerEndpointTest#testGetCredentialOffer

org.keycloak.testsuite.oid4vc.issuance.signing.OID4VCIssuerEndpointTest#testGetCredentialOfferWithABrokenNote

org.keycloak.testsuite.oid4vc.issuance.signing.OID4VCIssuerEndpointTest#testGetCredentialOfferURI

org.keycloak.testsuite.oid4vc.issuance.signing.OID4VCIssuerEndpointTest#testGetCredentialOfferWithoutAPreparedOffer

org.keycloak.testsuite.oid4vc.issuance.signing.OID4VCIssuerEndpointTest#testRequestCredentialUnsupportedFormat

org.keycloak.testsuite.oid4vc.issuance.signing.OID4VCIssuerEndpointTest#testRequestCredentialUnsupportedCredential

keycloak-github-bot bot left a comment

Choose a reason for hiding this comment

keycloak-github-bot bot left a comment

Choose a reason for hiding this comment

keycloak-github-bot bot commented May 8, 2024

Unreported flaky test detected

org.keycloak.testsuite.oid4vc.issuance.signing.OID4VCIssuerEndpointTest#testGetCredentialOfferUriUnsupportedCredential

org.keycloak.testsuite.oid4vc.issuance.signing.OID4VCIssuerEndpointTest#testGetCredentialOfferUriInvalidToken

org.keycloak.testsuite.oid4vc.issuance.signing.OID4VCIssuerEndpointTest#testRequestCredential

org.keycloak.testsuite.oid4vc.issuance.signing.OID4VCIssuerEndpointTest#testGetCredentialOfferUriUnauthorized

org.keycloak.testsuite.oid4vc.issuance.signing.OID4VCIssuerEndpointTest#testGetCredentialOfferUnauthorized

org.keycloak.testsuite.oid4vc.issuance.signing.OID4VCIssuerEndpointTest#testRequestCredentialInvalidToken

org.keycloak.testsuite.oid4vc.issuance.signing.OID4VCIssuerEndpointTest#testRequestCredentialUnauthorized

org.keycloak.testsuite.oid4vc.issuance.signing.OID4VCIssuerEndpointTest#testCredentialIssuance

org.keycloak.testsuite.oid4vc.issuance.signing.OID4VCIssuerEndpointTest#testGetCredentialOfferWithoutNonce

org.keycloak.testsuite.oid4vc.issuance.signing.OID4VCIssuerEndpointTest#testGetCredentialOffer

org.keycloak.testsuite.oid4vc.issuance.signing.OID4VCIssuerEndpointTest#testGetCredentialOfferWithABrokenNote

org.keycloak.testsuite.oid4vc.issuance.signing.OID4VCIssuerEndpointTest#testGetCredentialOfferURI

org.keycloak.testsuite.oid4vc.issuance.signing.OID4VCIssuerEndpointTest#testGetCredentialOfferWithoutAPreparedOffer

pruivo commented Apr 25, 2024 •

edited