Remove deprecated adapters #29040
Remove deprecated adapters #29040
Conversation
Signed-off-by: Douglas Palmer <dpalmer@redhat.com> Closes keycloak#28783
Closes keycloak#28778 Signed-off-by: Douglas Palmer <dpalmer@redhat.com>
Closes keycloak#28781 Signed-off-by: Douglas Palmer <dpalmer@redhat.com>
Closes keycloak#28780 Signed-off-by: Douglas Palmer <dpalmer@redhat.com>
Closes keycloak#28782 Signed-off-by: Douglas Palmer <dpalmer@redhat.com>
Closes keycloak#28779 Signed-off-by: Douglas Palmer <dpalmer@redhat.com>
Closes keycloak#28786 Signed-off-by: Douglas Palmer <dpalmer@redhat.com>
douglaspalmer
force-pushed
the
rm_adapters
branch
from
59abeaf
to
f715160
Compare
Done |
Signed-off-by: Douglas Palmer <dpalmer@redhat.com> Closes keycloak#28790
Closes keycloak#28789 Signed-off-by: Douglas Palmer <dpalmer@redhat.com>
douglaspalmer
force-pushed
the
rm_adapters
branch
5 times, most recently
from
cec2d32
to
063ea58
Compare
douglaspalmer
force-pushed
the
rm_adapters
branch
from
063ea58
to
a2bc59c
Compare
There was a problem hiding this comment.
I would have preferred to send different PRs because this is an enormous change. But once it is here let's try to merge it. 😄
Just two things:
- It seems that app severs for tomcat and jetty are completely gone now. So probably we can get rid of them in the app-server directory too. They create the app server to test adapters in that container.
- And I would also remove them from the ContainerConstants. You need to tweak the tests that contains them (if you see a test only for tomcat and/or jetty, you can remove it too). IIRC the adapter IT CI is only executed for wildfly right now (and maybe EAP in some other chain).
Probably we will need some changes in documentation, but we can do that once everything is removed in a follow-up.
Thanks!
There was a problem hiding this comment.
@douglaspalmer @jonkoops @rmartinc Thanks everyone for the review!
+1 that we can cleanup stuff from testsuite etc as a follow-up. I assume that we may review testsuite after we remove all adapters and do some more cleanup there #28795 . In the meantime, we can cleanup smaller chunks from testsuite (like jetty and tomcat etc), so separate task for #29089 is also good.
Closes #28783
Closes #28778
Closes #28781
Closes #28780
Closes #28782
Closes #28779
Closes #28786
Closes #28790
Closes #28789