Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Client type service account default type #29037

Merged
merged 15 commits into from May 2, 2024
Merged

Client type service account default type #29037

merged 15 commits into from May 2, 2024

Commits on May 1, 2024

  1. Adding additional non-applicable client fields to the default service… 

    …-account client type configuration.

Signed-off-by: Patrick Jennings <pajennin@redhat.com>
    @patrickjennings
    patrickjennings committed May 1, 2024
    Configuration menu
    Copy the full SHA
    78d7aa2 View commit details
    Browse the repository at this point in the history

  2. Creating TypedClientAttribute which maps clientmodel fields to standa… 

    …rd client type configurations.

Adding overrides for fields in TypeAwareClientModelDelegate required for
service-account client type.

Signed-off-by: Patrick Jennings <pajennin@redhat.com>
    @patrickjennings
    patrickjennings committed May 1, 2024
    Configuration menu
    Copy the full SHA
    80bd73f View commit details
    Browse the repository at this point in the history

  3. Splitting client type attribute enum into 3 separate enums, representing 

    the top level ClientModel fields, the extended attributes through the
client_attributes table, and the composable fields on
ClientRepresentation.

Signed-off-by: Patrick Jennings <pajennin@redhat.com>
    @patrickjennings
    patrickjennings committed May 1, 2024
    Configuration menu
    Copy the full SHA
    a493b67 View commit details
    Browse the repository at this point in the history

  4. Removing reflection use for client types. 

    Validation will be done in the RepresentationToModel methods that are responsible for the ClientRepresentation -> ClientModel create and update static methods.

Signed-off-by: Patrick Jennings <pajennin@redhat.com>

More updates

Signed-off-by: Patrick Jennings <pajennin@redhat.com>
    @patrickjennings
    patrickjennings committed May 1, 2024
    Configuration menu
    Copy the full SHA
    cced214 View commit details
    Browse the repository at this point in the history

  5. Update client utilzes type aware client property update method. 

    Signed-off-by: Patrick Jennings <pajennin@redhat.com>
    @patrickjennings
    patrickjennings committed May 1, 2024
    Configuration menu
    Copy the full SHA
    71ed131 View commit details
    Browse the repository at this point in the history

  6. If user inputted representation object does not contain non-null valu… 

    …e, try to get property value from the client. Type aware client model will return non-applicable or default value to keep fields consistent.

Signed-off-by: Patrick Jennings <pajennin@redhat.com>
    @patrickjennings
    patrickjennings committed May 1, 2024
    Configuration menu
    Copy the full SHA
    491f5ba View commit details
    Browse the repository at this point in the history

  7. Cleaning up RepresentationToModel 

    Signed-off-by: Patrick Jennings <pajennin@redhat.com>
    @patrickjennings
    patrickjennings committed May 1, 2024
    Configuration menu
    Copy the full SHA
    b46e3bb View commit details
    Browse the repository at this point in the history

  8. Fixing issue when updating client secret. 

    Signed-off-by: Patrick Jennings <pajennin@redhat.com>
    @patrickjennings
    patrickjennings committed May 1, 2024
    Configuration menu
    Copy the full SHA
    1100c1a View commit details
    Browse the repository at this point in the history

  9. Fixing issue where created clients would not have fullscope allowed, … 

    …because getter is a boolean and so cannot be null.

Signed-off-by: Patrick Jennings <pajennin@redhat.com>
    @patrickjennings
    patrickjennings committed May 1, 2024
    Configuration menu
    Copy the full SHA
    2ccb37e View commit details
    Browse the repository at this point in the history

  10. Need to be able to clear out client attributes on update as was allow… 

    …ed before and causing failures in integration tests.

Signed-off-by: Patrick Jennings <pajennin@redhat.com>
    @patrickjennings
    patrickjennings committed May 1, 2024
    Configuration menu
    Copy the full SHA
    43679e1 View commit details
    Browse the repository at this point in the history

  11. Fixing issues with redirectUri and weborigins defaults in type aware … 

    …clients.

Signed-off-by: Patrick Jennings <pajennin@redhat.com>
    @patrickjennings
    patrickjennings committed May 1, 2024
    Configuration menu
    Copy the full SHA
    e6c0497 View commit details
    Browse the repository at this point in the history

  12. Need to allow client attributes the ability to clear out values durin… 

    …g update.

Signed-off-by: Patrick Jennings <pajennin@redhat.com>
    @patrickjennings
    patrickjennings committed May 1, 2024
    Configuration menu
    Copy the full SHA
    4087e41 View commit details
    Browse the repository at this point in the history

  13. Renaming interface based on PR feedback. 

    Signed-off-by: Patrick Jennings <pajennin@redhat.com>
    @patrickjennings
    patrickjennings committed May 1, 2024
    Configuration menu
    Copy the full SHA
    9c81077 View commit details
    Browse the repository at this point in the history

  14. Shall be able to override URI sets with an empty set. 

    Signed-off-by: Patrick Jennings <pajennin@redhat.com>
    @patrickjennings
    patrickjennings committed May 1, 2024
    Configuration menu
    Copy the full SHA
    8f917d9 View commit details
    Browse the repository at this point in the history

  15. Comments around fields that are primitive and may cause problems dete… 

    …rmining whether to set sane default on create.

Signed-off-by: Patrick Jennings <pajennin@redhat.com>
    @patrickjennings
    patrickjennings committed May 1, 2024
    Configuration menu
    Copy the full SHA
    188e36d View commit details
    Browse the repository at this point in the history