Fix user-facing typos in Java code #28971
Merged
+88
−88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DimitriPapadopoulos
force-pushed
the
codespell_java
branch
from
b86aacb
to
dfbe56d
Compare
This was referenced May 3, 2024
Open
|
@DimitriPapadopoulos - some of the tests fail as they test for error messages in the responses. |
thomasdarimont
approved these changes
May 6, 2024
DimitriPapadopoulos
force-pushed
the
codespell_java
branch
from
dfbe56d
to
0e3328e
Compare
|
I have modified this pull request to include only fixes in Javadoc. Changes to error messages will follow in a distinct merge request (#29326). |
Signed-off-by: Dimitri Papadopoulos <3234522+DimitriPapadopoulos@users.noreply.github.com>
DimitriPapadopoulos
force-pushed
the
codespell_java
branch
from
0e3328e
to
bdd70c2
Compare
ahus1
approved these changes
May 6, 2024
|
Thank you for this PR, @DimitriPapadopoulos. Once you start changing Java code, please open a GitHub issue first and then link it to the PR as outlined in the CONTRIBUTING.md guide. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes documentation and user-visible messages, but excludes log messages.
This is a follow-up to #28890. This is currently an incomplete draft, I want to make sure I have got "only user-facing content excluding log messages" right.