New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FormSubmitButton that listens on FormState #28701
Add FormSubmitButton that listens on FormState #28701
Conversation
124164f
to
28f91f6
Compare
28f91f6
to
85943f5
Compare
85943f5
to
99b3fb0
Compare
99b3fb0
to
c604fe2
Compare
aca3123
to
13322f9
Compare
@jhchong92 Can you fix conflicts, please? We would like to get this merged if you and @jonkoops can finish up. |
13322f9
to
ef00cd2
Compare
@jhchong92 Please fix conflicts. |
I'll take another look after the PR is rebased :) |
ef00cd2
to
0ff9b29
Compare
@jonkoops rebased completed :) |
@jhchong92 seems there are conflicts again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's implement the second proposal, where isDisabled
can be passed as an override if needed.
0ff9b29
to
70c218a
Compare
I've applied the changes @jonkoops |
closes keycloak#28256 Signed-off-by: jchong <jhchong92@gmail.com>
70c218a
to
7bfab21
Compare
Wonderful, thanks a bunch for taking this on @jhchong92, we really appreciate it! |
Thank you @jonkoops ! I learned a lot from this, hope to contribute again in the future. |
closes #28256
Some forms allow submission on invalid and non-dirty state (e.g. Create Realm form). This behaviour provides more visible error messages if user clicks submit.
So, I decided to cater to this original behaviour by specifying it in
Props
.