Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Wildfly and EAP OIDC adapters #23381

Closed
Tracked by #28774
mposolda opened this issue Sep 20, 2023 · 3 comments · Fixed by #29115
Closed
Tracked by #28774

Remove Wildfly and EAP OIDC adapters #23381

mposolda opened this issue Sep 20, 2023 · 3 comments · Fixed by #29115
Assignees
@douglaspalmer
Labels
area/adapter/jee kind/eol release/25.0.0 team/core-clients
Milestone
25.0.0

Comments

@mposolda
Copy link
Contributor

Description

Those are already deprecated in Keycloak 22 (and before). There is replacement for them by using Elytron OIDC. Hence we can remove them from:

  • Keycloak codebase (including testsuite and distribution)
  • Documentation
  • Web page (downloads etc)
  • Will need to add something to release notes and/or migration guide about those being removed
@ghost ghost added the team/other label Sep 20, 2023
@mposolda mposolda added this to the 23.0.0 milestone Sep 20, 2023
@mposolda mposolda modified the milestones: 23.0.0, 24.0.0 Oct 26, 2023
@mposolda
Copy link
Contributor Author

Moving to Keycloak 25. The decision was to remove only Jetty adapters in Keycloak 24 (Related issue is #26255 ). The other adapters (including tomcat) might be removed afterwards in Keycloak 25.

@mposolda mposolda modified the milestones: 24.0.0, 25.0.0 Jan 24, 2024
@mposolda mposolda mentioned this issue Apr 16, 2024
Open
@douglaspalmer
Copy link
Contributor

douglaspalmer commented Apr 24, 2024 •
edited

@mposolda Does this include removing the wildfly-elytron OIDC adapter too?

douglaspalmer added a commit to douglaspalmer/keycloak that referenced this issue Apr 24, 2024
@douglaspalmer
Remove Wildfly and EAP OIDC adapters
b7c80df 
Closes keycloak#23381

Signed-off-by: Douglas Palmer <dpalmer@redhat.com>
@douglaspalmer douglaspalmer mentioned this issue Apr 24, 2024
Merged
douglaspalmer added a commit to douglaspalmer/keycloak that referenced this issue Apr 24, 2024
@douglaspalmer
Remove Wildfly and EAP OIDC adapters
72b8b55 
Closes keycloak#23381

Signed-off-by: Douglas Palmer <dpalmer@redhat.com>
douglaspalmer added a commit to douglaspalmer/keycloak that referenced this issue Apr 25, 2024
@douglaspalmer
Remove Wildfly and EAP OIDC adapters
9a113a8 
Closes keycloak#23381

Signed-off-by: Douglas Palmer <dpalmer@redhat.com>
douglaspalmer added a commit to douglaspalmer/keycloak that referenced this issue Apr 25, 2024
@douglaspalmer
Remove Wildfly and EAP OIDC adapters
788c11a 
Closes keycloak#23381

Signed-off-by: Douglas Palmer <dpalmer@redhat.com>
douglaspalmer added a commit to douglaspalmer/keycloak that referenced this issue Apr 25, 2024
@douglaspalmer
Remove Wildfly and EAP OIDC adapters
cec2d32 
Closes keycloak#23381

Signed-off-by: Douglas Palmer <dpalmer@redhat.com>
douglaspalmer added a commit to douglaspalmer/keycloak that referenced this issue Apr 25, 2024
@douglaspalmer
Remove Wildfly and EAP OIDC adapters
063ea58 
Closes keycloak#23381

Signed-off-by: Douglas Palmer <dpalmer@redhat.com>
douglaspalmer added a commit to douglaspalmer/keycloak that referenced this issue Apr 25, 2024
@douglaspalmer
Remove Wildfly and EAP OIDC adapters
325e836 
Closes keycloak#23381

Signed-off-by: Douglas Palmer <dpalmer@redhat.com>
douglaspalmer added a commit to douglaspalmer/keycloak that referenced this issue Apr 25, 2024
@douglaspalmer
Remove Wildfly and EAP OIDC adapters
e2d4ffc 
Closes keycloak#23381

Signed-off-by: Douglas Palmer <dpalmer@redhat.com>
douglaspalmer added a commit to douglaspalmer/keycloak that referenced this issue Apr 25, 2024
@douglaspalmer
Remove Wildfly and EAP OIDC adapters
6b13758 
Closes keycloak#23381

Signed-off-by: Douglas Palmer <dpalmer@redhat.com>
douglaspalmer added a commit to douglaspalmer/keycloak that referenced this issue Apr 25, 2024
@douglaspalmer
Remove Wildfly and EAP OIDC adapters
15f6ce5 
Closes keycloak#23381

Signed-off-by: Douglas Palmer <dpalmer@redhat.com>
douglaspalmer added a commit to douglaspalmer/keycloak that referenced this issue Apr 25, 2024
@douglaspalmer
Remove Wildfly and EAP OIDC adapters
71875eb 
Closes keycloak#23381

Signed-off-by: Douglas Palmer <dpalmer@redhat.com>
douglaspalmer added a commit to douglaspalmer/keycloak that referenced this issue Apr 25, 2024
@douglaspalmer
Remove Wildfly and EAP OIDC adapters
a525b5b 
Closes keycloak#23381

Signed-off-by: Douglas Palmer <dpalmer@redhat.com>
douglaspalmer added a commit to douglaspalmer/keycloak that referenced this issue Apr 26, 2024
@douglaspalmer
Remove Wildfly and EAP OIDC adapters
5765310 
Closes keycloak#23381

Signed-off-by: Douglas Palmer <dpalmer@redhat.com>
douglaspalmer added a commit to douglaspalmer/keycloak that referenced this issue Apr 26, 2024
@douglaspalmer
Remove Wildfly and EAP OIDC adapters
49afd8d 
Closes keycloak#23381

Signed-off-by: Douglas Palmer <dpalmer@redhat.com>
@mposolda
Copy link
Contributor Author

@mposolda Does this include removing the wildfly-elytron OIDC adapter too?

@douglaspalmer +1 . Adapter adapters/oidc/wildfly-elytron is supposed to be removed as well. WildFly has it's own OIDC adapter in it's own codebase, so we can remove everything on our side.

douglaspalmer added a commit to douglaspalmer/keycloak that referenced this issue Apr 26, 2024
@douglaspalmer
Remove Wildfly and EAP OIDC adapters
db0019b 
Closes keycloak#23381

Signed-off-by: Douglas Palmer <dpalmer@redhat.com>
@douglaspalmer douglaspalmer mentioned this issue Apr 26, 2024
Merged
douglaspalmer added a commit to douglaspalmer/keycloak that referenced this issue Apr 30, 2024
@douglaspalmer
Remove Wildfly and EAP OIDC adapters
5a2253a 
Closes keycloak#23381

Signed-off-by: Douglas Palmer <dpalmer@redhat.com>
douglaspalmer added a commit to douglaspalmer/keycloak that referenced this issue Apr 30, 2024
@douglaspalmer
Remove Wildfly and EAP OIDC adapters
122fe66 
Closes keycloak#23381

Signed-off-by: Douglas Palmer <dpalmer@redhat.com>
douglaspalmer added a commit to douglaspalmer/keycloak that referenced this issue May 1, 2024
@douglaspalmer
Remove Wildfly and EAP OIDC adapters
144634a 
Closes keycloak#23381

Signed-off-by: Douglas Palmer <dpalmer@redhat.com>
mposolda pushed a commit that referenced this issue May 2, 2024
@douglaspalmer @mposolda
Remove Wildfly and EAP OIDC adapters
e0176a7 
Closes #23381

Signed-off-by: Douglas Palmer <dpalmer@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@douglaspalmer douglaspalmer

Labels
area/adapter/jee kind/eol release/25.0.0 team/core-clients
Projects
None yet
Milestone
25.0.0
Development

Successfully merging a pull request may close this issue.

Remove Wildfly and EAP OIDC adapters douglaspalmer/keycloak
3 participants
@douglaspalmer @mposolda @stianst