New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use cache.compute() method to improve the replace retry loop #29081
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @pruivo - thank you for this PR. I have another question about serialization ... please see below.
...nfinispan/src/main/java/org/keycloak/models/sessions/infinispan/changes/ReplaceFunction.java
Show resolved
Hide resolved
Closes keycloak#29073 Signed-off-by: Pedro Ruivo <pruivo@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this change! I've reviewed it, and also tested it with a 3-node deployment on OpenShift with remote debugging to inspect the code, where it worked as expected.
Closes #29073