Skip to content

Commit

Permalink
Target and test .NET 7 instead of 6
Browse files Browse the repository at this point in the history
Where a concrete framework is required, target the most recent, which is
now .NET 7.

Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
  • Loading branch information
kevinoid committed Nov 14, 2022
1 parent b82acef commit 24b843e
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/dotnet.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,8 @@ jobs:
# https://github.com/actions/setup-dotnet/issues/93
# Poses problems for versions incompatible with worker image:
# https://github.com/actions/setup-dotnet/issues/23#issuecomment-523554330
# Note: Must quote value. 6.0 becomes 6, which silently fails.
- '6.0'
# Note: Must quote value. 7.0 becomes 7, which silently fails.
- '7.0'
# Uncomment to build using an earlier SDK version:
# - 3.1
env:
Expand Down
2 changes: 1 addition & 1 deletion NetCoreProject.UnitTests/NetCoreProject.UnitTests.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<Description>Unit tests for NetCoreProject.</Description>

<!-- Multi-target all frameworks to test, newest first (for VS runner) -->
<TargetFrameworks>net6.0</TargetFrameworks>
<TargetFrameworks>net7.0</TargetFrameworks>
<!-- Test older frameworks in CI (to avoid requiring devs to install) -->
<!--
TODO: Test opportunistically outside of CI?
Expand Down
2 changes: 1 addition & 1 deletion NetCoreProject/NetCoreProject.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@

<PropertyGroup Condition="'$(OutputType)'=='Exe'">
<!-- Need a "concrete" framework (i.e. not netstandard) for Exe -->
<TargetFramework>net6.0</TargetFramework>
<TargetFramework>net7.0</TargetFramework>

<!-- Configure class with Main method entry point -->
<StartupObject>NetCoreProject.Program</StartupObject>
Expand Down

0 comments on commit 24b843e

Please sign in to comment.