-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to declarative Python package config #767
base: master
Are you sure you want to change the base?
Conversation
workflow approval plz 🥺 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@deronnax before we go into details, I'd like to ask for the motivation behind this change when we could (and will eventually) migrate to build
and pyproject.toml
. Please help me see the value in this intermediary stage. Thank you!
@hartwork pyproject.toml is a bit of a bigger leap. initially I offered direct move to pyproject.toml but people were reluctant to do the leap. But if you are willing, I will do the conversion straight to pyproject.toml. |
@deronnax thanks for your reply! I'm trying to find a previous conversion about it up here, but I fail to find any. Have a link? Maybe it was even me who reluctant about it, to some extent I still am, but simplified personally I'll be good with any of But I'm not making the release files. @kevin1024 will you be okay to start using the @jairhenrique do you have any stakes in the |
6c96112
to
f6c46cc
Compare
@hartwork sorry I meant "people in general on GitHub", not the vcrpy community. Some people don't feel to do the jump to pyproject.toml yet. |
@deronnax I understand, thanks for the clarification 👍
Thanks! The CI may(?) need adjustment to use |
@kevin1024 what's your stance on the subject? I can also do the move to the pyproject.toml if you prefer. |
Hello! I’m afraid I haven’t been following new developments in Python packaging very closely for awhile now. My general opinion on this is: if it increases compatibility with the newer packaging ecosystem without breaking compatibility with any of our existing environments we support, then I am in favor. There are a number of Linux distributions that package VCR.py from source. I believe if we make this change it may also affect their build scripts, so ideally we would also coordinate with those maintainers. |
@kevin1024 that seems to be the case, I think you're in favor then. Regarding need to migrate https://packaging.python.org/en/latest/discussions/setup-py-deprecated/ could be of interest, but it's not meant as an argument to not migrate.
Speaking with my Gentoo downstream maintainer hat on here: Distros already need to support various ways to build Python software, use of |
@kevin1024 can we get a go :) ? |
No description provided.