New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix record of new_episodes mode #755

Open

vickyliin wants to merge 3 commits into kevin1024:master from vickyliin:fix-753-new_episodes-record

vickyliin commented Aug 3, 2023 •

edited

Fix #753

I found play_count is heavily relied on in the tests to check if a record is newly added or being played.

I'm wondering if

I should modify the logic of play_count to be added whenever a record has been played no matter from loaded cassettes or from a real request (like the change in this PR now) and change all the related tests
or I should find a work around

vickyliin added 3 commits

August 3, 2023 15:26


          use rewind() after _load

e768f17


          add test

3572b34


          Revert "add test"

facceff

This reverts commit 3572b34.

vickyliin marked this pull request as ready for review

August 7, 2023 03:53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment