Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for options in cmd #310

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

chris-kapstan
Copy link
Contributor

@chris-kapstan chris-kapstan commented Oct 13, 2023

Description of this change

Adds the capability to pass additional FX Options into the Setup() call for a command. This is required to apply options that must be applied to the parent app such as StopTimeout

Why is this change being made?

  • Chore (non-functional changes)
  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How was this tested? How can the reviewer verify your testing?

Test added in cmd_test.go that shows how you can alter the behavior of the fx App by passing in additional options to the .Setup call. The test has two cases, the first showcases the fx App exiting with an error during shutdown due to a timeout and the second shows how by passing in an option to increase the shutdown window the App no longer exits with an error.

Related issues

Checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have evaluated the security impact of this change, and OWASP Secure Coding Practices have been observed.
  • I have informed stakeholders of my changes.

@chris-kapstan chris-kapstan requested a review from a team as a code owner October 13, 2023 06:12
@chris-kapstan chris-kapstan force-pushed the fellowes/feat/cmd branch 2 times, most recently from bd6e2d1 to 351b846 Compare October 13, 2023 15:39
@sethyates sethyates merged commit f06a752 into ketch-com:main Nov 1, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants