feat: add support for options in cmd #310
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of this change
Adds the capability to pass additional FX Options into the
Setup()
call for a command. This is required to apply options that must be applied to the parent app such as StopTimeoutWhy is this change being made?
How was this tested? How can the reviewer verify your testing?
Test added in
cmd_test.go
that shows how you can alter the behavior of the fx App by passing in additional options to the.Setup
call. The test has two cases, the first showcases the fx App exiting with an error during shutdown due to a timeout and the second shows how by passing in an option to increase the shutdown window the App no longer exits with an error.Related issues
Checklist