fix: helm chart generation and helm pipeline #975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #975 +/- ##
==========================================
- Coverage 57.53% 57.46% -0.08%
==========================================
Files 119 119
Lines 9914 9914
==========================================
- Hits 5704 5697 -7
- Misses 4013 4018 +5
- Partials 197 199 +2
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: realanna <anna.reale@dynatrace.com> fix: removed useless files Signed-off-by: realanna <anna.reale@dynatrace.com> fix: helm pipeline Signed-off-by: realanna <anna.reale@dynatrace.com>
Signed-off-by: realanna <anna.reale@dynatrace.com>
RealAnna
force-pushed
the
fix/helm-validation-pipline
branch
from
0934499
to
1b4fd35
Compare
Signed-off-by: realanna <anna.reale@dynatrace.com>
Signed-off-by: realanna <anna.reale@dynatrace.com>
RealAnna
changed the title
Signed-off-by: realanna <anna.reale@dynatrace.com>
RealAnna
requested review from
thisthat,
thschue,
bacherfl,
mowies and
philipp-hinteregger
as code owners
Signed-off-by: realanna <anna.reale@dynatrace.com>
Signed-off-by: realanna <anna.reale@dynatrace.com>
Signed-off-by: realanna <anna.reale@dynatrace.com>
bacherfl
reviewed
Mar 7, 2023
Co-authored-by: Florian Bacher <florian.bacher@dynatrace.com> Signed-off-by: RealAnna <89971034+RealAnna@users.noreply.github.com>
mowies
reviewed
Mar 7, 2023
Co-authored-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> Signed-off-by: RealAnna <89971034+RealAnna@users.noreply.github.com>
Signed-off-by: realanna <anna.reale@dynatrace.com>
|
Kudos, SonarCloud Quality Gate passed!
|
thisthat
reviewed
Mar 7, 2023
mowies
approved these changes
Mar 7, 2023
thisthat
approved these changes
Mar 7, 2023
bacherfl
approved these changes
Mar 7, 2023
Merged
thschue
pushed a commit
to thschue/lifecycle-controller
that referenced
this pull request
Mar 7, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/keptn/lifecycle-toolkit/actions/runs/4345057277
Note
since this his already huge, helm docs will be updated in a separate pr