Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(helm-chart): ability to set hostNetwork for lifecycle operator deployment #3500

Merged
merged 5 commits into from May 13, 2024

Conversation

JLont
Copy link
Contributor

@JLont JLont commented May 7, 2024

Description

This PR adds the ability to set the .spec.template.spec.hostNetwork value for the lifecycle-operator deployment in the helm-chart values. By default it will be set to false.

This is required due to the webhook being blocked while using Cilium on managed Amazon EKS clusters. This makes it so other deployments won't be able to deploy on our clusters.

How to test

Added the default values to .github/scripts/.helm-tests.

Checklist

  • My PR fulfills the Definition of Done of the corresponding issue and not more (or parts if the issue is separated
    into multiple PRs)
  • I used descriptive commit messages to help reviewers understand my thought process
  • I signed off all my commits according to the Developer Certificate of Origin (DCO)
    see Contribution Guide
  • My PR title is formatted according to the semantic PR conventions described in
    the Contribution Guide
  • My code follows the style guidelines of this project (golangci-lint passes, YAMLLint passes)
  • I regenerated the auto-generated docs for Helm and the CRD documentation (if applicable)
  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation (if needed)
  • My changes result in all-green PR checks (first-time contributors need to ask a maintainer to approve their test runs)
  • New and existing unit and integration tests pass locally with my changes

Joost Lont added 2 commits May 7, 2024 15:34
Signed-off-by: Joost Lont <joost.lont@sue.nl>
Signed-off-by: Joost Lont <joost.lont@sue.nl>
@JLont JLont force-pushed the feature/chart-update-host-network branch from e9371ea to 25d6c15 Compare May 7, 2024 13:35
Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.36%. Comparing base (e048679) to head (e312efc).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3500   +/-   ##
=======================================
  Coverage   85.36%   85.36%           
=======================================
  Files         167      167           
  Lines        7412     7412           
=======================================
  Hits         6327     6327           
+ Misses        798      797    -1     
- Partials      287      288    +1     

see 3 files with indirect coverage changes

Flag Coverage Δ
certificate-operator 69.23% <ø> (ø)
component-tests 58.77% <ø> (ø)
lifecycle-operator 83.46% <ø> (ø)
metrics-operator 88.32% <ø> (ø)
scheduler 34.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: Joost Lont <joost.lont@sue.nl>
@github-actions github-actions bot added the documentation Improvements or additions to documentation label May 7, 2024
@JLont JLont force-pushed the feature/chart-update-host-network branch 2 times, most recently from dec7f4e to 5d6b6f8 Compare May 7, 2024 14:17
Copy link
Contributor

@odubajDT odubajDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try to add the parameter also to the Deployment here with default value false

JLont added 2 commits May 8, 2024 09:29
Signed-off-by: Joost Lont <joost.lont@xs4all.nl>
Signed-off-by: Joost Lont <joost.lont@xs4all.nl>
@JLont JLont force-pushed the feature/chart-update-host-network branch from 5d6b6f8 to e312efc Compare May 8, 2024 07:39
Copy link

sonarcloud bot commented May 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@odubajDT odubajDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contribution! :)

@RealAnna RealAnna merged commit c08bb07 into keptn:main May 13, 2024
43 checks passed
@JLont JLont deleted the feature/chart-update-host-network branch May 13, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation lifecycle-operator ops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants