New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(helm-chart): ability to set hostNetwork for lifecycle operator deployment #3500
Conversation
Signed-off-by: Joost Lont <joost.lont@sue.nl>
Signed-off-by: Joost Lont <joost.lont@sue.nl>
e9371ea
to
25d6c15
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3500 +/- ##
=======================================
Coverage 85.36% 85.36%
=======================================
Files 167 167
Lines 7412 7412
=======================================
Hits 6327 6327
+ Misses 798 797 -1
- Partials 287 288 +1 see 3 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: Joost Lont <joost.lont@sue.nl>
dec7f4e
to
5d6b6f8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's try to add the parameter also to the Deployment here with default value false
Signed-off-by: Joost Lont <joost.lont@xs4all.nl>
Signed-off-by: Joost Lont <joost.lont@xs4all.nl>
5d6b6f8
to
e312efc
Compare
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for contribution! :)
Description
This PR adds the ability to set the .spec.template.spec.hostNetwork value for the lifecycle-operator deployment in the helm-chart values. By default it will be set to
false
.This is required due to the webhook being blocked while using Cilium on managed Amazon EKS clusters. This makes it so other deployments won't be able to deploy on our clusters.
How to test
Added the default values to
.github/scripts/.helm-tests
.Checklist
into multiple PRs)
see Contribution Guide
the Contribution Guide