test: added catch statement in lifecycle-operator integration tests #3233
Conversation
Signed-off-by: utkarsh <utkarshumre@outlook.com>
Signed-off-by: utkarsh <utkarshumre@outlook.com>
UtkarshUmre
changed the title
…tor-integration-test
Signed-off-by: utkarsh <utkarshumre@outlook.com>
Signed-off-by: utkarsh <utkarshumre@outlook.com>
Signed-off-by: UtkarshUmre <112888849+UtkarshUmre@users.noreply.github.com>
…est' of https://github.com/UtkarshUmre/lifecycle-toolkit into add-catch-statement-in-lifecycle-operator-integration-test
Signed-off-by: UtkarshUmre <112888849+UtkarshUmre@users.noreply.github.com>
Signed-off-by: UtkarshUmre <112888849+UtkarshUmre@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3233 +/- ##
==========================================
+ Coverage 85.36% 87.00% +1.63%
==========================================
Files 167 162 -5
Lines 7412 8647 +1235
==========================================
+ Hits 6327 7523 +1196
- Misses 798 832 +34
- Partials 287 292 +5 see 91 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: UtkarshUmre <112888849+UtkarshUmre@users.noreply.github.com>
|
Hi @UtkarshUmre , thanks for your PR. Did you check if the resources you are catching the the tests are valid things to check if the test fails? All Please if possible go through each test and re-evaluate if it's needed. Thank you! |
…tor-integration-test
Signed-off-by: utkarsh <utkarshumre@outlook.com>
|
|
Hey @odubajDT I've re-evaluated the catch statements & addressed the issues with api conversions. i've made the necessary corrections, Could you please review it |
| @@ -11,3 +11,14 @@ spec: | |||
| file: 00-install.yaml | |||
| - assert: | |||
| file: 00-assert.yaml | |||
| catch: | |||
There was a problem hiding this comment.
Are you sure that keptnworkloadinstance and keptnapp are needed here? AFAIK they are not created in this test (please check 00-install.yaml). Also metrics-operator is not used here
Hi @UtkarshUmre , thank you for the adaptations. From what I see there are still a lot of information in the catch statement that are not needed. My tip would be: Try to go through the tests and look at the install and assert files -> from the content (what is applied to the cluster and what is checked/asserted) you should be able to see what resources make sense to be retrieved in case the test fails |
|
Hi @UtkarshUmre any updates on this? |
|
Hey @odubajDT I'm tied up with some work at the moment, but I'll revisit the PR issues in a couple of days |
|
@UtkarshUmre any updates on this please? |
|
@odubajDT Half of the file's done, but the rest needs another look. I'll update the PR soon. |
Signed-off-by: utkarsh <utkarshumre@outlook.com>
Signed-off-by: utkarsh <utkarshumre@outlook.com>
|
Description
This issue is about adding catch statements to integration tests for improved error handling.
Fixes #2698
Checklist
into multiple PRs)
see Contribution Guide
the Contribution Guide
Summary
In this pull request, I've implemented catch statements within the integration test. I've conducted thorough local testing to confirm their effectiveness in resolving the issue.