Fix de la règle @typescript-eslint/restrict-template-expressions (la …

…config par défaut avait changé)
keplr-team · Sep 5, 2023 · e70b630 · e70b630
1 parent b022af3
commit e70b630
Show file tree

Hide file tree

Showing 2 changed files with 36 additions and 1 deletion.
diff --git a/lib/index.js b/lib/index.js
@@ -310,7 +310,18 @@ module.exports = {
     '@typescript-eslint/restrict-plus-operands': 'error',
     '@typescript-eslint/restrict-template-expressions': [
       'error',
-      { allowNumber: true },
+      {
+        // On autorise les any, car il y a déjà d'autres règles qui empêchent les any excessifs
+        allowAny: true,
+
+        // On évite ainsi des null ou undefined avec les types de style string | undefined
+        allowNullish: false,
+
+        // ces types s'impriment de façon propre ou intuitive
+        allowBoolean: true,
+        allowNumber: true,
+        allowRegExp: true,
+      },
     ],
     '@typescript-eslint/return-await': ['error', 'always'],
     '@typescript-eslint/semi': ['error', 'always'],

diff --git a/test/__snapshots__/rules.test.ts.snap b/test/__snapshots__/rules.test.ts.snap
@@ -372,7 +372,11 @@ exports[`ESLint rules should match defined rules for e2e.js: Applied rules 1`] =
     "@typescript-eslint/restrict-template-expressions": [
       "error",
       {
+        "allowAny": true,
+        "allowBoolean": true,
+        "allowNullish": false,
         "allowNumber": true,
+        "allowRegExp": true,
       },
     ],
     "@typescript-eslint/return-await": [
@@ -2120,7 +2124,11 @@ exports[`ESLint rules should match defined rules for e2e.ts: Applied rules 1`] =
     "@typescript-eslint/restrict-template-expressions": [
       "error",
       {
+        "allowAny": true,
+        "allowBoolean": true,
+        "allowNullish": false,
         "allowNumber": true,
+        "allowRegExp": true,
       },
     ],
     "@typescript-eslint/return-await": [
@@ -3868,7 +3876,11 @@ exports[`ESLint rules should match defined rules for js: Applied rules 1`] = `
     "@typescript-eslint/restrict-template-expressions": [
       "error",
       {
+        "allowAny": true,
+        "allowBoolean": true,
+        "allowNullish": false,
         "allowNumber": true,
+        "allowRegExp": true,
       },
     ],
     "@typescript-eslint/return-await": [
@@ -5616,7 +5628,11 @@ exports[`ESLint rules should match defined rules for test.js: Applied rules 1`]
     "@typescript-eslint/restrict-template-expressions": [
       "error",
       {
+        "allowAny": true,
+        "allowBoolean": true,
+        "allowNullish": false,
         "allowNumber": true,
+        "allowRegExp": true,
       },
     ],
     "@typescript-eslint/return-await": [
@@ -7364,7 +7380,11 @@ exports[`ESLint rules should match defined rules for test.ts: Applied rules 1`]
     "@typescript-eslint/restrict-template-expressions": [
       "error",
       {
+        "allowAny": true,
+        "allowBoolean": true,
+        "allowNullish": false,
         "allowNumber": true,
+        "allowRegExp": true,
       },
     ],
     "@typescript-eslint/return-await": [
@@ -9112,7 +9132,11 @@ exports[`ESLint rules should match defined rules for ts: Applied rules 1`] = `
     "@typescript-eslint/restrict-template-expressions": [
       "error",
       {
+        "allowAny": true,
+        "allowBoolean": true,
+        "allowNullish": false,
         "allowNumber": true,
+        "allowRegExp": true,
       },
     ],
     "@typescript-eslint/return-await": [