Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: check build for arm architecture #988

Merged

Conversation

AkashKumar7902
Copy link
Member

@AkashKumar7902 AkashKumar7902 commented Oct 9, 2023

Related Issue

  • Info about Issue or bug

Closes: #986

Describe the changes you've made

support for architecture came in #253

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Please let us know if any test cases are added

Please describe the tests(if any). Provide instructions how its affecting the coverage.

Describe if there is any unusual behaviour of your code(Write NA if there isn't)

A clear and concise description of it.

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

Screenshots (if any)

Original Updated
original screenshot updated screenshot

@charankamarapu charankamarapu self-requested a review October 9, 2023 15:59
@charankamarapu
Copy link
Member

We need both amd(which was present by default) as well as arm. You can check PR-#985 and for Github action I have deleted there will be corresponding Github action for amd , Like go.yml, main.yml, sample-run.yml. By default they run on amd you should also have arm check for it.

@AkashKumar7902 AkashKumar7902 marked this pull request as draft October 9, 2023 16:42
@AkashKumar7902 AkashKumar7902 changed the title Bug check build for arm architecture Fix: check build for arm architecture Oct 9, 2023
@AkashKumar7902
Copy link
Member Author

AkashKumar7902 commented Oct 9, 2023

the go arm binary is not running on amd machine. I am looking for a workaround.

@charankamarapu
Copy link
Member

try with the example given in issue to use GOARCH=arm. If possible include both amd and arm in one file only for each action.

@AkashKumar7902
Copy link
Member Author

@charankamarapu I think i couldn't get you. In 766da40, i have added architecture=arm which sets the go env variable GOARCH to arm. I believe you meant something else.

@charankamarapu
Copy link
Member

charankamarapu commented Oct 11, 2023

You can refer this https://opensource.com/article/21/1/go-cross-compiling. If you have already referred this and made changes and it didn't work please inform me. I don't think architecture=arm will work. try directly defining GOARCH in command.

@AkashKumar7902 AkashKumar7902 marked this pull request as ready for review October 11, 2023 17:17
@charankamarapu
Copy link
Member

you forgot to sign the commit

Signed-off-by: Akash Kumar <meakash7902@gmail.com>
Signed-off-by: Akash Kumar <meakash7902@gmail.com>
Signed-off-by: Akash Kumar <meakash7902@gmail.com>
Signed-off-by: Akash Kumar <meakash7902@gmail.com>
Signed-off-by: Akash Kumar <meakash7902@gmail.com>
Signed-off-by: Akash Kumar <meakash7902@gmail.com>
Signed-off-by: Akash Kumar <meakash7902@gmail.com>
Signed-off-by: Akash Kumar <meakash7902@gmail.com>
Signed-off-by: Akash Kumar <meakash7902@gmail.com>
Signed-off-by: Akash Kumar <meakash7902@gmail.com>
Signed-off-by: Akash Kumar <meakash7902@gmail.com>
Signed-off-by: Akash Kumar <meakash7902@gmail.com>
Signed-off-by: Akash Kumar <meakash7902@gmail.com>
Signed-off-by: Akash Kumar <meakash7902@gmail.com>
Signed-off-by: Akash Kumar <meakash7902@gmail.com>
Signed-off-by: Akash Kumar <meakash7902@gmail.com>
Signed-off-by: Akash Kumar <meakash7902@gmail.com>
Signed-off-by: Akash Kumar <meakash7902@gmail.com>
Signed-off-by: Akash Kumar <meakash7902@gmail.com>
Signed-off-by: Akash Kumar <meakash7902@gmail.com>
Signed-off-by: Akash Kumar <meakash7902@gmail.com>
Signed-off-by: Akash Kumar <meakash7902@gmail.com>
Signed-off-by: Akash Kumar <meakash7902@gmail.com>
Signed-off-by: Akash Kumar <meakash7902@gmail.com>
@AkashKumar7902 AkashKumar7902 force-pushed the bug-check-build-for-arm-architecture branch 2 times, most recently from 1d46c0c to 3ad2ec4 Compare October 12, 2023 06:39
Copy link
Member

@charankamarapu charankamarapu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ship it !

@charankamarapu charankamarapu merged commit e48cae9 into keploy:main Oct 12, 2023
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: check build for arm architecture
2 participants