New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fixed re-record for docker #1876
Conversation
Signed-off-by: EraKin575 <tejaskumar574@gmail.com>
Signed-off-by: EraKin575 <tejaskumar574@gmail.com>
Signed-off-by: EraKin575 <tejaskumar574@gmail.com>
@EraKin575 Please fix the build checks ! |
Signed-off-by: EraKin575 <tejaskumar574@gmail.com>
pkg/service/record/utils.go
Outdated
@@ -54,3 +55,21 @@ func waitForPort(ctx context.Context, host, port string) error { | |||
} | |||
} | |||
} | |||
func replaceHostToIP(currentURL string, ipAddress string) (string, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just move this method in common utils and export
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We dont need to re write
Signed-off-by: EraKin575 <tejaskumar574@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Related Issue
Closes: #[issue number that will be closed through this PR]
Describe the changes you've made
fixed rerecord with docker
Type of change
Please let us know if any test cases are added
Please describe the tests(if any). Provide instructions how its affecting the coverage.
Describe if there is any unusual behaviour of your code(Write
NA
if there isn't)A clear and concise description of it.
Checklist:
Screenshots (if any)